You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/05/05 00:26:37 UTC
Re: Review Request 33139: Drill-1827: Unit test framework reports
expected and actual values backwards in unordered comparison
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33139/#review82452
-----------------------------------------------------------
Ship it!
Ship It!
- Venki Korukanti
On April 13, 2015, 7:10 p.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33139/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:10 p.m.)
>
>
> Review request for drill and Venki Korukanti.
>
>
> Bugs: DRILL-1827
> https://issues.apache.org/jira/browse/DRILL-1827
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> There was a bug in the unit test framework that was flipping the expected and actual result sets. I added a try/finally block as well to make sure we cleanup the resources from the queries even if the result set verification fails.
>
>
> Diffs
> -----
>
> exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java d05c896
>
> Diff: https://reviews.apache.org/r/33139/diff/
>
>
> Testing
> -------
>
> Uint test framework changes only, unit tests are passing.
>
>
> Thanks,
>
> Jason Altekruse
>
>