You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/26 07:07:35 UTC

[GitHub] [rocketmq] samz406 opened a new pull request, #4210: change word UNKNOW to UNKNOWN

samz406 opened a new pull request, #4210:
URL: https://github.com/apache/rocketmq/pull/4210

   issue #4200
   
   ## Brief changelog 
   
   client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
   
   client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionState.java
   
   example/src/main/java/org/apache/rocketmq/example/benchmark/TransactionProducer.java
   
   example/src/main/java/org/apache/rocketmq/example/transaction/TransactionListenerImpl.java
   
   test/src/test/java/org/apache/rocketmq/test/client/producer/transaction/TransactionalMsgIT.java
   
   docs/en/Example_Transaction.md
   docs/cn/RocketMQ_Example.md
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #4210: change word UNKNOW to UNKNOWN

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on PR #4210:
URL: https://github.com/apache/rocketmq/pull/4210#issuecomment-1120558587

   There is a problem here, the code will report an error after  the user upgrades to this version, this seems to be a compatibility issue, and it is worth considering more


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] aaron-ai commented on pull request #4210: change word UNKNOW to UNKNOWN

Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4210:
URL: https://github.com/apache/rocketmq/pull/4210#issuecomment-1254837056

   @samz406 Thx for contributing, could you rebase the develop branch so that we could merge this pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4210: change word UNKNOW to UNKNOWN

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4210:
URL: https://github.com/apache/rocketmq/pull/4210#issuecomment-1109566917

   
   [![Coverage Status](https://coveralls.io/builds/48571429/badge)](https://coveralls.io/builds/48571429)
   
   Coverage decreased (-0.06%) to 51.941% when pulling **1e28701c8ba15934a5d4139a36e31335133f958b on samz406:develop** into **9de7be47850684c329cc6d324b01950386c5963b on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4210: change word UNKNOW to UNKNOWN

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4210:
URL: https://github.com/apache/rocketmq/pull/4210#issuecomment-1109566910

   
   [![Coverage Status](https://coveralls.io/builds/48571429/badge)](https://coveralls.io/builds/48571429)
   
   Coverage decreased (-0.06%) to 51.941% when pulling **1e28701c8ba15934a5d4139a36e31335133f958b on samz406:develop** into **9de7be47850684c329cc6d324b01950386c5963b on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4210: change word UNKNOW to UNKNOWN

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on code in PR #4210:
URL: https://github.com/apache/rocketmq/pull/4210#discussion_r858376406


##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -319,7 +319,7 @@ public void run() {
                 TransactionCheckListener transactionCheckListener = DefaultMQProducerImpl.this.checkListener();
                 TransactionListener transactionListener = getCheckListener();
                 if (transactionCheckListener != null || transactionListener != null) {
-                    LocalTransactionState localTransactionState = LocalTransactionState.UNKNOW;
+                    LocalTransactionState localTransactionState = LocalTransactionState.UNKNOWN;

Review Comment:
   This is a very careful PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org