[GitHub] [tvm] junrushao commented on a diff in pull request #12797: [TIR] Construct the inverse in SuggestIndexMap

[GitBox <gi...@apache.org>]

junrushao commented on code in PR #12797:
URL: https://github.com/apache/tvm/pull/12797#discussion_r972395704


##########
include/tvm/tir/index_map.h:
##########
@@ -133,16 +145,19 @@ class IndexMapNode : public Object {
   void VisitAttrs(AttrVisitor* v) {
     v->Visit("initial_indices", &initial_indices);
     v->Visit("final_indices", &final_indices);
+    v->Visit("inverse_index_map", &inverse_index_map);
   }
 
   bool SEqualReduce(const IndexMapNode* other, SEqualReducer equal) const {
     return equal.DefEqual(initial_indices, other->initial_indices) &&
-           equal(final_indices, other->final_indices);
+           equal(final_indices, other->final_indices) &&
+           equal(inverse_index_map, other->inverse_index_map);

Review Comment:
   Do we need to include `inverse_index_map` in structural equality check? Consider a case where this field is optional so `lhs` doesn't have it while `rhs` does, and should they be considered the same?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org