You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/04/21 17:57:03 UTC

[GitHub] [avro] cutting commented on issue #842: AVRO-2723: Refactor ReflectData to allow derived classes to customize default values for fields

cutting commented on issue #842:
URL: https://github.com/apache/avro/pull/842#issuecomment-617319686


   New public & protected methods need javadoc comments.  Also, the new fields should probably be private, not protected.
   
   Might the cache be better as WeakHashMap<Class,Object>?
   
   I don't see where isFieldInitialized is called.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org