You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jinho Kim <jh...@apache.org> on 2014/04/16 08:38:50 UTC
Review Request 20409: TAJO-765: Incorrect Configuration Classpaths
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20409/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-765
https://issues.apache.org/jira/browse/TAJO-765
Repository: tajo
Description
-------
Configuration should be loaded in classpath before JAR files
Diffs
-----
tajo-dist/src/main/bin/tajo 24dce60f6c222020ed20c2503d8bc01cb0c2f34e
tajo-dist/src/main/conf/tajo-env.sh e61415c05bcd729efff38198a701a58a58b5e91d
Diff: https://reviews.apache.org/r/20409/diff/
Testing
-------
Thanks,
Jinho Kim
Re: Review Request 20409: TAJO-765: Incorrect Configuration Classpaths
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20409/#review40511
-----------------------------------------------------------
Ship it!
+1
No problem. This issue must be completed before 0.8.0 release. Thank you for the quick patch.
- Hyunsik Choi
On April 16, 2014, 4:13 p.m., Jinho Kim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20409/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 4:13 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-765
> https://issues.apache.org/jira/browse/TAJO-765
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Configuration should be loaded in classpath before JAR files
>
>
> Diffs
> -----
>
> tajo-dist/src/main/bin/tajo 24dce60f6c222020ed20c2503d8bc01cb0c2f34e
> tajo-dist/src/main/conf/tajo-env.sh e61415c05bcd729efff38198a701a58a58b5e91d
>
> Diff: https://reviews.apache.org/r/20409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinho Kim
>
>
Re: Review Request 20409: TAJO-765: Incorrect Configuration Classpaths
Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20409/
-----------------------------------------------------------
(Updated April 16, 2014, 7:13 a.m.)
Review request for Tajo.
Bugs: TAJO-765
https://issues.apache.org/jira/browse/TAJO-765
Repository: tajo
Description
-------
Configuration should be loaded in classpath before JAR files
Diffs (updated)
-----
tajo-dist/src/main/bin/tajo 24dce60f6c222020ed20c2503d8bc01cb0c2f34e
tajo-dist/src/main/conf/tajo-env.sh e61415c05bcd729efff38198a701a58a58b5e91d
Diff: https://reviews.apache.org/r/20409/diff/
Testing
-------
Thanks,
Jinho Kim
Re: Review Request 20409: TAJO-765: Incorrect Configuration Classpaths
Posted by Jinho Kim <jh...@apache.org>.
> On April 16, 2014, 7:02 a.m., Hyunsik Choi wrote:
> > +1
> >
> > The patch looks good to me. I tested it on a local cluster.
I'm sorry hyunsik
I've updated the TAJO_CLASSPATH, please review again
- Jinho
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20409/#review40509
-----------------------------------------------------------
On April 16, 2014, 7:13 a.m., Jinho Kim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20409/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 7:13 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-765
> https://issues.apache.org/jira/browse/TAJO-765
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Configuration should be loaded in classpath before JAR files
>
>
> Diffs
> -----
>
> tajo-dist/src/main/bin/tajo 24dce60f6c222020ed20c2503d8bc01cb0c2f34e
> tajo-dist/src/main/conf/tajo-env.sh e61415c05bcd729efff38198a701a58a58b5e91d
>
> Diff: https://reviews.apache.org/r/20409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinho Kim
>
>
Re: Review Request 20409: TAJO-765: Incorrect Configuration Classpaths
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20409/#review40509
-----------------------------------------------------------
Ship it!
+1
The patch looks good to me. I tested it on a local cluster.
- Hyunsik Choi
On April 16, 2014, 3:38 p.m., Jinho Kim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20409/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 3:38 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-765
> https://issues.apache.org/jira/browse/TAJO-765
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Configuration should be loaded in classpath before JAR files
>
>
> Diffs
> -----
>
> tajo-dist/src/main/bin/tajo 24dce60f6c222020ed20c2503d8bc01cb0c2f34e
> tajo-dist/src/main/conf/tajo-env.sh e61415c05bcd729efff38198a701a58a58b5e91d
>
> Diff: https://reviews.apache.org/r/20409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinho Kim
>
>