[GitHub] tajo pull request: TAJO-2103: JdbcMetadataProviderBase need to dif...

[hyunsik <gi...@git.apache.org>]

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/990#issuecomment-219886726
  
    Could you explain the purpose of this patch? 
    
    See setDatabase() in the below. The variable 'database' already contains 'mapped_dbname'.
    ```
    public JdbcTablespace(String name, URI uri, JSONObject config) {
        super(name, uri, config);
        setDatabase();
        setJdbcProperties();
      }
    
      private void setDatabase() {
        if (config.containsKey(CONFIG_KEY_MAPPED_DATABASE)) {
          database = this.config.getAsString(CONFIG_KEY_MAPPED_DATABASE);
        } else {
          database = ConnectionInfo.fromURI(uri).database();
        }
      }
    ```
    
    But, your patch changes as the below. It's a duplicate.
    ```
    public MetadataProvider getMetadataProvider() {
       return new PgSQLMetadataProvider(this, database, ConnectionInfo.fromURI(uri).database());
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---