You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/12 09:52:45 UTC
[GitHub] [incubator-hudi] vinothchandar opened a new pull request #1212:
[WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
vinothchandar opened a new pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212
- Storage Type replaced with Table Type (remaining instances)
- View types replaced with query types;
- ReadOptimized view referred as Snapshot Query
- TableFileSystemView sub interfaces renamed to BaseFileOnly and Slice Views
- HoodieDataFile renamed to HoodieBaseFile
- Hive Sync tool will register RO tables for MOR with a `_ro` suffix
- Datasource/Deltastreamer options renamed accordingly
TDB
[ ] Support fallback to old config values as well, so migration is painless
[ ] Config for controlling _ro suffix addition
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1212: [HUDI-509]
Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#issuecomment-574421454
@n3nash are you able to review this? or any other committer really.. (wish there was a gh team we could mention.. )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1212: [HUDI-509]
Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#issuecomment-575380133
LGTM overall. Left minor comments. Was just thinking about them. Feel free to ignore if its too much refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r365570835
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java
##########
@@ -27,21 +27,21 @@
import java.util.Objects;
/**
- * Hoodie data file.
+ * Hoodie base file.
*/
-public class HoodieDataFile implements Serializable {
Review comment:
This means ORC support is coming 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1212:
[HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367179607
##########
File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -53,30 +53,44 @@
public class HiveSyncTool {
private static final Logger LOG = LogManager.getLogger(HiveSyncTool.class);
- private final HoodieHiveClient hoodieHiveClient;
- public static final String SUFFIX_REALTIME_TABLE = "_rt";
+ public static final String SUFFIX_SNAPSHOT_TABLE = "_rt";
+ public static final String SUFFIX_READ_OPTIMIZED_TABLE = "_ro";
Review comment:
Not sure if it's the best user-experience to augment the table name with a postfix for all tables..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1212: [HUDI-509]
Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#issuecomment-575197796
@n3nash Addressed comments.. Responded to the renaming issue. Let me know what you think and we can hopefully merge after CI passes?
I will follow up with site doc changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367678245
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
##########
@@ -36,22 +36,22 @@
@JsonProperty("fileLen")
private long fileLen;
- public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+ public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
if (null == dto) {
return null;
}
- HoodieDataFile dataFile = null;
+ HoodieBaseFile dataFile = null;
if (null != dto.fileStatus) {
- dataFile = new HoodieDataFile(FileStatusDTO.toFileStatus(dto.fileStatus));
+ dataFile = new HoodieBaseFile(FileStatusDTO.toFileStatus(dto.fileStatus));
} else {
- dataFile = new HoodieDataFile(dto.fullPath);
+ dataFile = new HoodieBaseFile(dto.fullPath);
dataFile.setFileLen(dto.fileLen);
}
return dataFile;
}
- public static DataFileDTO fromHoodieDataFile(HoodieDataFile dataFile) {
+ public static DataFileDTO fromHoodieDataFile(HoodieBaseFile dataFile) {
Review comment:
'fromHoodieBaseFile' instead ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki
restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r366214234
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/DefaultSource.scala
##########
@@ -50,20 +50,14 @@ class DefaultSource extends RelationProvider
optParams: Map[String, String],
schema: StructType): BaseRelation = {
// Add default options for unspecified read options keys.
- val parameters = Map(VIEW_TYPE_OPT_KEY -> DEFAULT_VIEW_TYPE_OPT_VAL) ++ optParams
+ val parameters = Map(QUERY_TYPE_OPT_KEY -> DEFAULT_QUERY_TYPE_OPT_VAL) ++ optParams
val path = parameters.get("path")
if (path.isEmpty) {
throw new HoodieException("'path' must be specified.")
}
- if (parameters(VIEW_TYPE_OPT_KEY).equals(VIEW_TYPE_REALTIME_OPT_VAL)) {
- throw new HoodieException("Realtime view not supported yet via data source. Please use HiveContext route.")
- }
-
- if (parameters(VIEW_TYPE_OPT_KEY).equals(VIEW_TYPE_INCREMENTAL_OPT_VAL)) {
- new IncrementalRelation(sqlContext, path.get, optParams, schema)
- } else {
+ if (parameters(QUERY_TYPE_OPT_KEY).equals(QUERY_TYPE_SNAPSHOT_OPT_VAL)) {
Review comment:
this is a behavior change... previously MOR realtime view errored out here.. now we just return the same RO query results with a warning..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r365570835
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java
##########
@@ -27,21 +27,21 @@
import java.util.Objects;
/**
- * Hoodie data file.
+ * Hoodie base file.
*/
-public class HoodieDataFile implements Serializable {
Review comment:
IMO, this means ORC support is coming 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367687094
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
##########
@@ -36,22 +36,22 @@
@JsonProperty("fileLen")
private long fileLen;
- public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+ public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
if (null == dto) {
return null;
}
- HoodieDataFile dataFile = null;
+ HoodieBaseFile dataFile = null;
if (null != dto.fileStatus) {
- dataFile = new HoodieDataFile(FileStatusDTO.toFileStatus(dto.fileStatus));
+ dataFile = new HoodieBaseFile(FileStatusDTO.toFileStatus(dto.fileStatus));
} else {
- dataFile = new HoodieDataFile(dto.fullPath);
+ dataFile = new HoodieBaseFile(dto.fullPath);
dataFile.setFileLen(dto.fileLen);
}
return dataFile;
}
- public static DataFileDTO fromHoodieDataFile(HoodieDataFile dataFile) {
+ public static DataFileDTO fromHoodieDataFile(HoodieBaseFile dataFile) {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367190262
##########
File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -53,30 +53,44 @@
public class HiveSyncTool {
private static final Logger LOG = LogManager.getLogger(HiveSyncTool.class);
- private final HoodieHiveClient hoodieHiveClient;
- public static final String SUFFIX_REALTIME_TABLE = "_rt";
+ public static final String SUFFIX_SNAPSHOT_TABLE = "_rt";
+ public static final String SUFFIX_READ_OPTIMIZED_TABLE = "_ro";
Review comment:
@n3nash the reason was.. without this, it gets kind of confusing that the snapshot query on COW hits the table with no prefix and on MOR, its not the snapshot table.. So wanted to clearly call out `_ro` ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367679877
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -249,10 +249,10 @@ private void ensurePartitionLoadedCorrectly(String partition) {
*
* @param statuses List of File-Status
*/
- private Stream<HoodieDataFile> convertFileStatusesToDataFiles(FileStatus[] statuses) {
+ private Stream<HoodieBaseFile> convertFileStatusesToDataFiles(FileStatus[] statuses) {
Review comment:
convertFileStatusesToBaseFiles instead ? No strong opinion on these. I think it should be okay to leave it as is since the return type is indicative already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367687172
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -249,10 +249,10 @@ private void ensurePartitionLoadedCorrectly(String partition) {
*
* @param statuses List of File-Status
*/
- private Stream<HoodieDataFile> convertFileStatusesToDataFiles(FileStatus[] statuses) {
+ private Stream<HoodieBaseFile> convertFileStatusesToDataFiles(FileStatus[] statuses) {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1212: [HUDI-509]
Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#issuecomment-575512172
@bhasudha good catch. I cleaned up what you pointed out.. but there are still tons of variables named `dataFile` instead of `baseFile`. I created a JIRA for later..
@n3nash On the suffix, I believe this is the least path of change for existing users. I believe most users will be using teh _rt table with MOR.. So we can't rename that or drop the suffix there... Its better to add it to the RO table to make it clear.. I even added a flag to hive sync so that existing users can skip _ro suffix if needed..
Ideally we had no suffix on the snapshot table and only did a special _ro suffix... or even drop the _ro talbe altogether.. but this is a much larger change.. We can pursue this on top of what this PR does anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367678068
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
##########
@@ -36,22 +36,22 @@
@JsonProperty("fileLen")
private long fileLen;
- public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+ public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
Review comment:
@vinothchandar Do we want to rename the method as well to 'toHoodieBaseFile' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367472578
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/SyncableFileSystemView.java
##########
@@ -18,12 +18,15 @@
package org.apache.hudi.common.table;
+import org.apache.hudi.common.table.TableFileSystemView.BaseFileOnlyView;
+import org.apache.hudi.common.table.TableFileSystemView.SliceView;
+
/**
- * A consolidated file-system view interface exposing both realtime and read-optimized views along with
+ * A consolidated file-system view interface exposing both full and basefile only views along with
Review comment:
okay .. `complete` sounds better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367687060
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
##########
@@ -36,22 +36,22 @@
@JsonProperty("fileLen")
private long fileLen;
- public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+ public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on a change in pull request
#1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367179366
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/SyncableFileSystemView.java
##########
@@ -18,12 +18,15 @@
package org.apache.hudi.common.table;
+import org.apache.hudi.common.table.TableFileSystemView.BaseFileOnlyView;
+import org.apache.hudi.common.table.TableFileSystemView.SliceView;
+
/**
- * A consolidated file-system view interface exposing both realtime and read-optimized views along with
+ * A consolidated file-system view interface exposing both full and basefile only views along with
Review comment:
s/full/complete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki
restructuring
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r366207936
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -160,9 +160,9 @@ public Operation convert(String value) throws ParameterException {
@Parameter(names = {"--target-table"}, description = "name of the target table in Hive", required = true)
public String targetTableName;
- @Parameter(names = {"--storage-type"}, description = "Type of Storage. COPY_ON_WRITE (or) MERGE_ON_READ",
+ @Parameter(names = {"--table-type"}, description = "Type of table. COPY_ON_WRITE (or) MERGE_ON_READ",
Review comment:
I tried retaining `--storage-type` as well. but have to choose betwen this and the new `--table-type`to mark as required.. Whichever we pick, it wont be ideal. So choose to simply rename, requiring the users to make a small change in the command, when upgrading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1212: [WIP] [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r365570835
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java
##########
@@ -27,21 +27,21 @@
import java.util.Objects;
/**
- * Hoodie data file.
+ * Hoodie base file.
*/
-public class HoodieDataFile implements Serializable {
Review comment:
IMO, This means ORC support is coming 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services