You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/06/29 14:39:01 UTC

[commons-statistics] 02/06: Fix SonarCloud: Use assertEquals

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit c966c50007a86738b2dfde9d339ee6f06654ce95
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Jun 29 15:23:26 2020 +0100

    Fix SonarCloud: Use assertEquals
---
 .../apache/commons/statistics/distribution/GammaDistributionTest.java | 2 +-
 .../statistics/distribution/HypergeometricDistributionTest.java       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
index 7f32c4c..7bf8b62 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
@@ -268,7 +268,7 @@ public class GammaDistributionTest extends ContinuousDistributionAbstractTest {
                     continue;
                 }
                 final String[] tokens = line.split(", ");
-                Assertions.assertTrue(tokens.length == 2, "expected two floating-point values");
+                Assertions.assertEquals(2, tokens.length, "expected two floating-point values");
                 final double x = Double.parseDouble(tokens[0]);
                 final String msg = "x = " + x + ", shape = " + shape +
                                    ", scale = 1.0";
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
index c3f3271..a5aa9d9 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
@@ -287,12 +287,12 @@ public class HypergeometricDistributionTest extends DiscreteDistributionAbstract
         final int k = 0;
         final HypergeometricDistribution dist = new HypergeometricDistribution(N, m, n);
 
-        Assertions.assertTrue(Precision.compareTo(1.0, dist.upperCumulativeProbability(k), 1) == 0);
+        Assertions.assertEquals(0, Precision.compareTo(1.0, dist.upperCumulativeProbability(k), 1));
         Assertions.assertTrue(Precision.compareTo(dist.cumulativeProbability(k), 0.0, 1) > 0);
 
         // another way to calculate the upper cumulative probability
         final double upper = 1.0 - dist.cumulativeProbability(k) + dist.probability(k);
-        Assertions.assertTrue(Precision.compareTo(1.0, upper, 1) == 0);
+        Assertions.assertEquals(0, Precision.compareTo(1.0, upper, 1));
     }
 
     @Test