[jira] Commented: (THRIFT-565) Structs containing typedefs for incomparable objects will be considered comparable

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743408#action_12743408 ] 

David Reiss commented on THRIFT-565:
------------------------------------

Does this even build?  I think you need to move the *t_list cast outside of the true_type call, (and probably add some extra parens).  Actually, it would probably be better to just do one true_type call at the start of that function.

> Structs containing typedefs for incomparable objects will be considered comparable
> ----------------------------------------------------------------------------------
>
>                 Key: THRIFT-565
>                 URL: https://issues.apache.org/jira/browse/THRIFT-565
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2
>
>         Attachments: thrift-565.patch
>
>
> The is_comparable method in the Java code generator doesn't resolve typedefs. This means that if you typedef a map or set, for instance, structs including fields of that typedef will be considered comparable even though they should not be.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.