You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/13 12:39:41 UTC
Review Request 70631: Templatized two sorters for both random and DRF.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70631/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9782
https://issues.apache.org/jira/browse/MESOS-9782
Repository: mesos
Description
-------
Templatized two sorters for both random and DRF.
Diffs
-----
src/tests/sorter_tests.cpp 9aee2b41b0d3c978bca6bd2d7ad28e32506a648a
Diff: https://reviews.apache.org/r/70631/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70631: Templatized two sorters for both random and
DRF.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70631/#review215213
-----------------------------------------------------------
Ship it!
Weird commit message? I guess you forgot "tests". E.g.
"Templatized two more sorter tests for both random and DRF."
- Benjamin Mahler
On May 13, 2019, 12:39 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70631/
> -----------------------------------------------------------
>
> (Updated May 13, 2019, 12:39 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9782
> https://issues.apache.org/jira/browse/MESOS-9782
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Templatized two sorters for both random and DRF.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp 9aee2b41b0d3c978bca6bd2d7ad28e32506a648a
>
>
> Diff: https://reviews.apache.org/r/70631/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70631: Templatized two sorter tests for both
random and DRF.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70631/#review215214
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70630, 70631]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 13, 2019, 5:39 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70631/
> -----------------------------------------------------------
>
> (Updated May 13, 2019, 5:39 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9782
> https://issues.apache.org/jira/browse/MESOS-9782
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Templatized two sorter tests for both random and DRF.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp 9aee2b41b0d3c978bca6bd2d7ad28e32506a648a
>
>
> Diff: https://reviews.apache.org/r/70631/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>