[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6272: Support dynamic change agent.ignore_suffix on java agent.

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6272:
URL: https://github.com/apache/skywalking/pull/6272#discussion_r565919152



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManagerExtendService.java
##########
@@ -84,4 +92,10 @@ public AbstractTracerContext createTraceContext(String operationName, boolean fo
     public void statusChanged(final GRPCChannelStatus status) {
         this.status = status;
     }
+
+    void handleIgnoreSuffixPatternsChanged() {
+        if (StringUtil.isNotBlank(ignoreSuffixPatternsWatcher.getIgnoreSuffixPatterns())) {
+            ignoreSuffixArray = ignoreSuffixPatternsWatcher.getIgnoreSuffixPatterns().split(",");

Review comment:
       > The ignoreSuffixArray doesn't have volatile key word, due to another thread is watching and updating the value, the latest value will not be affected in some threads immediately. According to this kind of update is not urgent, it should be fine.
   
   Since most of the notifications of config centers are not real-time (have delay) themselves, the fields not being `volatile` may be acceptable if it has no side effects.
   
   > According to this kind of update is not urgent, it should be fine. But I am to check with you two, have we agreed this is our conclusion?
   
   I don't remember we have this conclusion before. TBH, I didn't notice this part indeed 🤦🏻‍♂️




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org