You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/19 11:01:05 UTC

[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3586: [ISSUE #3221]Feature/record log in user

dragon-zhang commented on code in PR #3586:
URL: https://github.com/apache/incubator-shenyu/pull/3586#discussion_r901086994


##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/event/user/UserChangedEvent.java:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.model.event.user;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.model.entity.DashboardUserDO;
+import org.apache.shenyu.admin.model.enums.EventTypeEnum;
+import org.apache.shenyu.admin.model.event.AdminDataModelChangedEvent;
+
+import java.util.Objects;
+
+/**
+ * UserChangedEvent.
+ */
+public class UserChangedEvent extends AdminDataModelChangedEvent {
+    
+    
+    /**
+     * Create a new {@code UserChangedEvent}.operator is unknown.
+     *
+     * @param source Current user state
+     * @param before Before the change user state
+     * @param type   event type
+     */
+    public UserChangedEvent(final DashboardUserDO source, final DashboardUserDO before, final EventTypeEnum type, final String operator) {
+        super(source, before, type, operator);
+    }
+    
+    @Override
+    public String buildContext() {
+        final DashboardUserDO after = (DashboardUserDO) getAfter();
+        if (Objects.isNull(getBefore())) {
+            return String.format("the selector [%s] is %s", after.getUserName(), StringUtils.lowerCase(getType().getType().toString()));
+        }
+        return String.format("the selector [%s] is %s : %s", after.getUserName(), StringUtils.lowerCase(getType().getType().toString()), contrast());
+        
+    }
+    
+    private String contrast() {
+        final DashboardUserDO before = (DashboardUserDO) getBefore();
+        Objects.requireNonNull(before);
+        final DashboardUserDO after = (DashboardUserDO) getAfter();
+        Objects.requireNonNull(after);
+        if (Objects.equals(before, after)) {
+            return "it no change";
+        }
+        final StringBuilder builder = new StringBuilder();
+        if (!Objects.equals(before.getUserName(), after.getUserName())) {
+            builder.append(String.format("name[%s => %s] ", before.getUserName(), after.getUserName()));
+        }
+        if (!Objects.equals(before.getPassword(), after.getPassword())) {
+            builder.append("password is changed...");
+        }
+        if (!Objects.equals(before.getRole(), after.getRole())) {
+            builder.append(String.format("role[%s => %s] ", before.getRole(), after.getRole()));
+        }
+        if (!Objects.equals(before.getEnabled(), after.getEnabled())) {
+            builder.append(String.format("enable[%s => %s] ", before.getEnabled(), after.getEnabled()));
+        }
+
+        return builder.toString();
+    }
+    

Review Comment:
   How about add  a `getChangedUser` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org