[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3434: [ZEPPELIN-4281] Fixed unusable after cluster mode restarts interpreter

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #3434: [ZEPPELIN-4281] Fixed unusable after cluster mode restarts interpreter
URL: https://github.com/apache/zeppelin/pull/3434#discussion_r319740047
 
 

 ##########
 File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
 ##########
 @@ -340,7 +344,21 @@ private void putClusterMeta() {
     meta.put(ClusterMeta.LATEST_HEARTBEAT, LocalDateTime.now());
     meta.put(ClusterMeta.STATUS, ClusterMeta.ONLINE_STATUS);
 
-    clusterManagerClient.putClusterMeta(ClusterMetaType.INTP_PROCESS_META, interpreterGroupId, meta);
+    clusterManagerClient.putClusterMeta(INTP_PROCESS_META, interpreterGroupId, meta);
+  }
+
+  private void deleteClusterMeta() {
+    if (!zconf.isClusterMode()){
+      return;
+    }
+
+    try {
+      // delete interpreter cluster meta
+      clusterManagerClient.deleteClusterMeta(INTP_PROCESS_META, interpreterGroupId);
+      Thread.sleep(300);
 
 Review comment:
   When `clusterManagerClient` operation metadata operations, it is asynchronous, so it can be more reliable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services