You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/29 00:39:58 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request, #4878: Fixed end of file indenting and code completion for ANTLR v4
lkishalmi opened a new pull request, #4878:
URL: https://github.com/apache/netbeans/pull/4878
Well, if we would have a 16-rc3 this would be a nice to have.
This one makes the formatting work if the editing happens at the end of the file.
The code completion has a fix and a feature creep. At the end of the file due to the bug in `AntlrTokenSequence` it was offering (`lexer`, `parser`, `grammar`).
The feature creep is a trivial one. We already have the unknown references collected during parsing, so why not offer to define those while not in a rule definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4878: Fixed end of file indenting and code completion for ANTLR v4
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4878:
URL: https://github.com/apache/netbeans/pull/4878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4878: Fixed end of file indenting and code completion for ANTLR v4
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4878:
URL: https://github.com/apache/netbeans/pull/4878#issuecomment-1295776185
@lkishalmi we aim to have at least 3 release candidates, so 16-rc3 is happening. Have retriggered the failing tests (failure in binary downloads so not related to changes). I'll wait for @matthiasblaesing review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4878: Fixed end of file indenting and code completion for ANTLR v4
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4878:
URL: https://github.com/apache/netbeans/pull/4878#issuecomment-1296336268
@neilcsmith-net Thanks for the merge!
@matthiasblaesing I've tried to solve this indenting issue, but that got too convoluted, and caused other issues. I fear I have to rewrite the formatting code for that. So far what that's just heuristics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists