[GitHub] [superset] michael-s-molina commented on a diff in pull request #20512: fix(sql lab): Save Dataset Modal Autocomplete should display list when overwritting

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #20512:
URL: https://github.com/apache/superset/pull/20512#discussion_r912167281


##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -165,6 +165,11 @@ export interface SelectProps extends PickedSelectProps {
    * Will not apply to predefined `options` array when users are not searching.
    */
   sortComparator?: typeof DEFAULT_SORT_COMPARATOR;
+  /**
+   * Customize who the container node is.
+   * Parent node by default.
+   */
+  getPopupContainer?: (triggerNode?: any) => any;

Review Comment:
   `getPopupContainer` comes from Ant Design. Can you include it in `PickedSelectProps` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org