You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/11 03:24:27 UTC

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4190: fix: fix graphql cannot cancel

likyh commented on code in PR #4190:
URL: https://github.com/apache/incubator-devlake/pull/4190#discussion_r1066540109


##########
plugins/helper/graphql_async_client.go:
##########
@@ -163,6 +164,9 @@ func (apiClient *GraphqlAsyncClient) Query(q interface{}, variables map[string]i
 		default:
 			var dataErrors []graphql.DataError
 			dataErrors, err := apiClient.client.Query(apiClient.ctx, q, variables)
+			if err == context.Canceled {
+				return nil, errors.Default.Wrap(err, `context canceled`)
+			}

Review Comment:
   yeah, return type defined for this type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org