[GitHub] [linkis] peacewong commented on a diff in pull request #4155: [ISSUE-2393]UDFLoadEngineConnHook should reuse executor created before

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4155:
URL: https://github.com/apache/linkis/pull/4155#discussion_r1098660442


##########
linkis-computation-governance/linkis-engineconn/linkis-computation-engineconn/src/main/scala/org/apache/linkis/engineconn/computation/executor/hook/UDFLoadEngineConnHook.scala:
##########
@@ -174,11 +174,11 @@ abstract class UDFLoad extends Logging {
     logger.info(s"Successful to execute function code ${runType}, type : ${udfType}")
   }
 
-  protected def loadUDF(labels: Array[Label[_]]): Unit = {
+  protected def loadUDF(): Unit = {
 
     val codes = getFunctionCode()
     if (null != codes && codes.nonEmpty) {
-      val executor = ExecutorManager.getInstance.getExecutorByLabels(labels)
+      val executor = ExecutorManager.getInstance.getReportExecutor

Review Comment:
   The Executor here needs to be obtained through Labels, and the default Executor cannot be used, because UDF supports different languages. For Spark, there are different UDF registration languages such as SQL, Python, and Scala.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org