[GitHub] [superset] jinghua-qa commented on pull request #18850: test(native filter): add new native filter test for time column filter

[GitBox <gi...@apache.org>]

jinghua-qa commented on pull request #18850:
URL: https://github.com/apache/superset/pull/18850#issuecomment-1050119376


   > @jinghua-qa The size of this file is getting quite big and a lot of functionality is being repeated between the tests. I think it's time to refactor this code and extract the common behaviors to functions so it's easier to read.
   
   That is a very good suggestion~ I will plan for this refactor project and do it in another PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org