You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2021/07/01 05:22:17 UTC

[Impala-ASF-CR] IMPALA-9822: Add warnings when row format delimiters are ignored on non-text/sequence tables

Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17589

to look at the new patch set (#4).

Change subject: IMPALA-9822: Add warnings when row format delimiters are ignored on non-text/sequence tables
......................................................................

IMPALA-9822: Add warnings when row format delimiters are ignored on
non-text/sequence tables

When users create a non-text/sequence table the row format gets ignored.
To avoid surprising results in subsequent queries, users should be
warned about the row format being ignored. So users can make sure if
they want to change the file type instead.

Fix: This patch adds a warning message in analyzing Create Table
statement, when row format delimited fields are non empty and file
format is not TEXTFILE/SEQUENCEFILE.

Tests: Added a FE test to verify the warning message.

Change-Id: I6fff8f26556ff3854403a418891a41d2a27f01a9
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
2 files changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/17589/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fff8f26556ff3854403a418891a41d2a27f01a9
Gerrit-Change-Number: 17589
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>