You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena <se...@cloudera.com> on 2015/06/01 17:52:26 UTC
Re: Review Request 34522: HIVE-10748 Replace StringBuffer with
StringBuilder where possible
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34522/#review85989
-----------------------------------------------------------
Ship it!
Looks good. The StringBuilder is not being used in places where multi-thread could access shared data.
- Sergio Pena
On May 30, 2015, 2:43 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34522/
> -----------------------------------------------------------
>
> (Updated May 30, 2015, 2:43 a.m.)
>
>
> Review request for hive and Chao Sun.
>
>
> Bugs: HIVE-10748
> https://issues.apache.org/jira/browse/HIVE-10748
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10748 Replace StringBuffer with StringBuilder where possible
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java 6d6bbc2ee2bca67645356089046a39a3b6969df0
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveBaseChar.java 012c28b1a0024b7292a97076f42de1097dae6b2a
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java 309d0427da3f17a85d16da0e0dca46ad29a1c48e
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatException.java 265d08dec6d3e260adfadfe7f629592ebeb5039d
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/data/TestJsonSerDe.java 2947c4333b925e0beabd8a85b188419a4d71a2e3
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/DelimitedInputWriter.java eae91cbd79ebb47e59263e8e47b8acdb457d576d
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3c2548635b95509da8cbdf474149c01da0662bbb
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 329e5da5c4675ad3d5f57fbdbddfc5ea168a6dbe
> jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java 8a0671fc28c4e8326df068f7de5cf278c863e362
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java 52147bcbd0bd214b62e52d4ed2a6775e04a94143
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 835015f249684820a9f0eb453d3316a98af52e00
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b87a0c54f482c32e460930978b691bcdb5
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java a9d2dbf1f7ddccaf71ce06a14e9681ab559186bb
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 4423cd1a9960c68b74788f41e386bea105cee4eb
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java 4a16b4c196c7080b1ec64d8ffdc25f359698b4d6
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java c5f03d94672a80849400e51a238bcec1db56659d
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java acd9bf5017ca23578616a5bd9b902d2c2abed1ef
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java f7e1dbce4ef1c985b8f2987df413aed0ab087051
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 0de74882f3b92aa979c1960ac64023d3c750b876
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java e477f04d83715f5488e72bddd8527728faeb6789
> ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java 7108a47676a6a8e2765f098c1799d08e587db58e
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 086d9a2b1740a8dc8560667c19826b7dff6cb75b
> ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java 9e197331bffb8db4b02aa5d5d842d68d55f7001a
> ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 8dff2fcee46a4d366bef559576348e9ea8ef6336
> ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 87a25480740df061e0918228d71dd9ec8e08a275
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java aa291b9b1f704c682c82d85675c5de17f3965403
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b8e18eafb67307c9b974194de28482fa8a7c6f2a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 847d75199d6d614bd17ea852a4e3e87bf6911be7
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java f26225a72c34252c8fdf615bd34b59532376c5de
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java f3f7d95ef90f3e4f1beacecb4d681030bd69a231
> serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java 19fe952f5e84755d1e7a8b752997c084dab339b9
> service/src/java/org/apache/hive/service/auth/HttpAuthUtils.java 3ef55779a6bde85193ca63ec9683cf9f67d6a39d
>
> Diff: https://reviews.apache.org/r/34522/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>