You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 09:37:28 UTC
[GitHub] [doris] englefly opened a new pull request, #14895: [fix](nereids)add slot desc for order key
englefly opened a new pull request, #14895:
URL: https://github.com/apache/doris/pull/14895
# Proposed changes
fix regression case: `select k1 from baseall order by k1 % 5;`
##Root cause:
Nereids only create slot descriptor for order key, whose expr is slot. For expression `k1 % 5`, there is no corresponding slot desc.
##Solution:
add alias for `k1 % 5`, and create slot desc for alias
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14895:
URL: https://github.com/apache/doris/pull/14895#issuecomment-1340938534
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.83 seconds
load time: 441 seconds
storage size: 17123356278 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207130556_clickbench_pr_59403.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1042839611
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? extends Plan> topN, PlanTra
return mergeFragment;
}
+ private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {
Review Comment:
`this.addExprIdSlotRefPair(alias.getExprId(), slotRef);`
we need an ExprId to link slotRef.
there is no exprId in expressions like `k % 5`, that why I wrap it into an alias to get the exprId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #14895:
URL: https://github.com/apache/doris/pull/14895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14895:
URL: https://github.com/apache/doris/pull/14895#issuecomment-1345593320
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1042270725
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? extends Plan> topN, PlanTra
return mergeFragment;
}
+ private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {
Review Comment:
i think, we do not need to re-generate orderKey list. just mod generateTupleDesc to generate slot for non-SlotReference key is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1043070856
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? extends Plan> topN, PlanTra
return mergeFragment;
}
+ private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14895: [fix](nereids)add slot desc for order key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14895:
URL: https://github.com/apache/doris/pull/14895#issuecomment-1345593314
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org