You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by va...@apache.org on 2023/04/26 23:23:29 UTC
[couchdb] branch main updated: Another flaky couch_js fix
This is an automated email from the ASF dual-hosted git repository.
vatamane pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/couchdb.git
The following commit(s) were added to refs/heads/main by this push:
new 0d1175a4f Another flaky couch_js fix
0d1175a4f is described below
commit 0d1175a4f1bfee8b1eb2e2d96a114aac83a2e43b
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Wed Apr 26 18:41:22 2023 -0400
Another flaky couch_js fix
After the previous fix, now the flakiness moved on to the next line.
Remove the extra assertion to avoid it generating flaky tests. The main
assertion is already checked above that we get a crash.
---
src/couch/test/eunit/couch_js_tests.erl | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/couch/test/eunit/couch_js_tests.erl b/src/couch/test/eunit/couch_js_tests.erl
index 09cab59a5..ccd2cd0b5 100644
--- a/src/couch/test/eunit/couch_js_tests.erl
+++ b/src/couch/test/eunit/couch_js_tests.erl
@@ -274,9 +274,7 @@ should_exit_on_internal_error() ->
% It may fail and just exit the process. That's expected as well
throw:{os_process_error, _} ->
ok
- end,
- % Expect the process to be dead
- ?assertThrow({os_process_error, _}, couch_query_servers:proc_prompt(Proc, [<<"reset">>])).
+ end.
trigger_oom(Proc) ->
Status =