[GitHub] [ozone] GlenGeng commented on a change in pull request #2052: HDDS-4985. [SCM HA Security] When Ratis enable, SCM secure cluster is not working.

[GitBox <gi...@apache.org>]

GlenGeng commented on a change in pull request #2052:
URL: https://github.com/apache/ozone/pull/2052#discussion_r595772986



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisRequest.java
##########
@@ -86,9 +94,14 @@ public Message encode() throws InvalidProtocolBufferException {
     methodBuilder.setName(operation);
 
     final List<MethodArgument> args = new ArrayList<>();
+
+    int paramCounter = 0;
     for (Object argument : arguments) {
       final MethodArgument.Builder argBuilder = MethodArgument.newBuilder();
-      argBuilder.setType(argument.getClass().getName());
+      // Set actual method parameter type, not actual argument type.
+      // This is done to avoid MethodNotFoundException in case if argument is

Review comment:
       Nice change!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org