[jira] Commented: (HARMONY-2527) [classlib][awt]Component.paint method should check if passed parameter in null

["Alexei Zakharov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466700 ] 

Alexei Zakharov commented on HARMONY-2527:
------------------------------------------

Andrey, could you add all testcases from the patch for HARMONY-2587 to your ContainerRTest1.patch please? I can close HARMONY-2587 as a duplicate after this. 

> [classlib][awt]Component.paint method should check if passed parameter in null
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-2527
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2527
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Nikolay Kuznetsov
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: Container1.patch, ContainerRTest1.patch
>
>
> RI implementations of paint methods checks if passed Graphics parameter is null. I've found several bugs[1] in Sun's database indicating activity on adding check to paint methods. In most of the real cases null value was passed because the component was clipped or invisible(and it seems to be OK).
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4036712
>      http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4191142
> Attached test passes on RI and throws NPE on harmony implementation.
> RI
> java test
> true
> true
> true
> true
> true
> true
> Harmony:
> false
> java.lang.NullPointerException
>         at java.awt.Container.paintComponentsImpl(Container.java)
>         at java.awt.Container.paint(Container.java:930)
>         at test.testPaint(test.java:58)
>         at test.main(test.java:119)
> false
> java.lang.NullPointerException
>         at java.awt.Container.paintComponentsImpl(Container.java)
>         at java.awt.Container.paintComponents(Container.java:977)
>         at test.testPaintComponents(test.java:70)
>         at test.main(test.java:122)
> false
> java.lang.NullPointerException
>         at java.awt.Container.paintComponentsImpl(Container.java)
>         at java.awt.Container.paint(Container.java:930)
>         at java.awt.Container.print(Container.java:318)
>         at test.testPrint(test.java:82)
>         at test.main(test.java:123)
> false
> java.lang.NullPointerException
>         at java.awt.Container.paintComponentsImpl(Container.java)
>         at java.awt.Container.paintComponents(Container.java:977)
>         at java.awt.Container.printComponents(Container.java:968)
>         at test.testPrintComponents(test.java:94)
>         at test.main(test.java:124)
> false
> java.lang.NullPointerException
>         at java.awt.Container.paintComponentsImpl(Container.java)
>         at java.awt.Container.paint(Container.java:930)
>         at java.awt.Component.update(Component.java:3447)
>         at java.awt.Container.update(Container.java:339)
>         at test.testUpdate(test.java:106)
>         at test.main(test.java:125)
> false

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.