You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2015/12/30 19:52:29 UTC
Review Request 41803: GEODE-718: Sanitize passwords in gfsh history
file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Kirk Lund.
Repository: geode
Description
-------
GEODE-718: Sanitize passwords in gfsh history file
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41803/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh
history file
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/#review112581
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Dec. 30, 2015, 6:57 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41803/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 6:57 p.m.)
>
>
> Review request for geode, Anthony Baker and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-718: Sanitize passwords in gfsh history file
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh
history file
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/#review112598
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Dec. 30, 2015, 6:57 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41803/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 6:57 p.m.)
>
>
> Review request for geode, Anthony Baker and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-718: Sanitize passwords in gfsh history file
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh
history file
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/#review112591
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Dec. 30, 2015, 6:57 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41803/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 6:57 p.m.)
>
>
> Review request for geode, Anthony Baker and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-718: Sanitize passwords in gfsh history file
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh
history file
Posted by Jacob Barrett <jb...@amduat.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/#review112592
-----------------------------------------------------------
Ship it!
Ship It!
- Jacob Barrett
On Dec. 30, 2015, 10:57 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41803/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 10:57 a.m.)
>
>
> Review request for geode, Anthony Baker and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-718: Sanitize passwords in gfsh history file
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh
history file
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41803/
-----------------------------------------------------------
(Updated Dec. 30, 2015, 6:57 p.m.)
Review request for geode, Anthony Baker and Kirk Lund.
Repository: geode
Description
-------
GEODE-718: Sanitize passwords in gfsh history file
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java dc3fbe19c89b4650a5a4770f3cd10dada3c04912
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41803/diff/
Testing
-------
Thanks,
Jens Deppe