You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Nirmal Fernando <ni...@gmail.com> on 2013/12/17 02:46:07 UTC

Re: git commit: Fixing STRATOS-299

Lahiru,

I think this is not the correct fix. Manula should know better. I think the
correct fix is to change the event stream definition.
On Dec 17, 2013 6:55 AM, <la...@apache.org> wrote:

> Updated Branches:
>   refs/heads/master 1d320e592 -> ef07f2b14
>
>
> Fixing STRATOS-299
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/ef07f2b1
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/ef07f2b1
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/ef07f2b1
>
> Branch: refs/heads/master
> Commit: ef07f2b1437e0b380f77409bbf9b2154e413c2a3
> Parents: 1d320e5
> Author: Lahiru Sandaruwan <la...@apache.org>
> Authored: Tue Dec 17 06:58:44 2013 +0530
> Committer: Lahiru Sandaruwan <la...@apache.org>
> Committed: Tue Dec 17 06:58:44 2013 +0530
>
> ----------------------------------------------------------------------
>  .../cep/artifacts/event-formatters/FaultMessageEventFormatter.xml  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/ef07f2b1/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
> ----------------------------------------------------------------------
> diff --git
> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
> index c594b5a..9d91cef 100644
> ---
> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
> +++
> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
> @@ -3,7 +3,7 @@
>    statistics="disable" trace="enable" xmlns="
> http://wso2.org/carbon/eventformatter">
>    <from streamName="fault_message" version="1.0.0"/>
>    <mapping customMapping="enable" type="json">
> -
>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","network_partition_id":"{{network_partition_id}}","member_id":"{{member_id}}"}}</inline>
> +
>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","partition_id":"{{partition_id}}","member_id":"{{member_id}}"}}</inline>
>    </mapping>
>    <to eventAdaptorName="JMSOutputAdaptor" eventAdaptorType="jms">
>      <property
> name="transport.jms.Destination">summarized-health-stats</property>
>
>

Re: git commit: Fixing STRATOS-299

Posted by Lahiru Sandaruwan <la...@wso2.com>.
On Tue, Dec 17, 2013 at 9:43 AM, Lahiru Sandaruwan <la...@wso2.com> wrote:

> This fix needs to be there. Autoscaler needs the partition id, not network
> partition id for member fault event.
>
> We may also have to fix at agent to send partition id, if it currently
> send network partition id.
>

Sorry, this needs to be fixed in CEP side, not from agent.

>
>
> On Tue, Dec 17, 2013 at 7:16 AM, Nirmal Fernando <ni...@gmail.com>wrote:
>
>> Lahiru,
>>
>> I think this is not the correct fix. Manula should know better. I think
>> the correct fix is to change the event stream definition.
>> On Dec 17, 2013 6:55 AM, <la...@apache.org> wrote:
>>
>>> Updated Branches:
>>>   refs/heads/master 1d320e592 -> ef07f2b14
>>>
>>>
>>> Fixing STRATOS-299
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
>>> Commit:
>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/ef07f2b1
>>> Tree:
>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/ef07f2b1
>>> Diff:
>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/ef07f2b1
>>>
>>> Branch: refs/heads/master
>>> Commit: ef07f2b1437e0b380f77409bbf9b2154e413c2a3
>>> Parents: 1d320e5
>>> Author: Lahiru Sandaruwan <la...@apache.org>
>>> Authored: Tue Dec 17 06:58:44 2013 +0530
>>> Committer: Lahiru Sandaruwan <la...@apache.org>
>>> Committed: Tue Dec 17 06:58:44 2013 +0530
>>>
>>> ----------------------------------------------------------------------
>>>  .../cep/artifacts/event-formatters/FaultMessageEventFormatter.xml  | 2
>>> +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/ef07f2b1/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>>> ----------------------------------------------------------------------
>>> diff --git
>>> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>>> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>>> index c594b5a..9d91cef 100644
>>> ---
>>> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>>> +++
>>> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>>> @@ -3,7 +3,7 @@
>>>    statistics="disable" trace="enable" xmlns="
>>> http://wso2.org/carbon/eventformatter">
>>>    <from streamName="fault_message" version="1.0.0"/>
>>>    <mapping customMapping="enable" type="json">
>>> -
>>>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","network_partition_id":"{{network_partition_id}}","member_id":"{{member_id}}"}}</inline>
>>> +
>>>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","partition_id":"{{partition_id}}","member_id":"{{member_id}}"}}</inline>
>>>    </mapping>
>>>    <to eventAdaptorName="JMSOutputAdaptor" eventAdaptorType="jms">
>>>      <property
>>> name="transport.jms.Destination">summarized-health-stats</property>
>>>
>>>
>
>
> --
> --
> Lahiru Sandaruwan
> Software Engineer,
> Platform Technologies,
> WSO2 Inc., http://wso2.com
> lean.enterprise.middleware
>
> email: lahirus@wso2.com cell: (+94) 773 325 954
> blog: http://lahiruwrites.blogspot.com/
> twitter: http://twitter.com/lahirus
> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
>
>


-- 
--
Lahiru Sandaruwan
Software Engineer,
Platform Technologies,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware

email: lahirus@wso2.com cell: (+94) 773 325 954
blog: http://lahiruwrites.blogspot.com/
twitter: http://twitter.com/lahirus
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146

Re: git commit: Fixing STRATOS-299

Posted by Lahiru Sandaruwan <la...@wso2.com>.
This fix needs to be there. Autoscaler needs the partition id, not network
partition id for member fault event.

We may also have to fix at agent to send partition id, if it currently send
network partition id.


On Tue, Dec 17, 2013 at 7:16 AM, Nirmal Fernando <ni...@gmail.com>wrote:

> Lahiru,
>
> I think this is not the correct fix. Manula should know better. I think
> the correct fix is to change the event stream definition.
> On Dec 17, 2013 6:55 AM, <la...@apache.org> wrote:
>
>> Updated Branches:
>>   refs/heads/master 1d320e592 -> ef07f2b14
>>
>>
>> Fixing STRATOS-299
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/ef07f2b1
>> Tree:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/ef07f2b1
>> Diff:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/ef07f2b1
>>
>> Branch: refs/heads/master
>> Commit: ef07f2b1437e0b380f77409bbf9b2154e413c2a3
>> Parents: 1d320e5
>> Author: Lahiru Sandaruwan <la...@apache.org>
>> Authored: Tue Dec 17 06:58:44 2013 +0530
>> Committer: Lahiru Sandaruwan <la...@apache.org>
>> Committed: Tue Dec 17 06:58:44 2013 +0530
>>
>> ----------------------------------------------------------------------
>>  .../cep/artifacts/event-formatters/FaultMessageEventFormatter.xml  | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/ef07f2b1/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>> ----------------------------------------------------------------------
>> diff --git
>> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>> index c594b5a..9d91cef 100644
>> ---
>> a/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>> +++
>> b/extensions/cep/artifacts/event-formatters/FaultMessageEventFormatter.xml
>> @@ -3,7 +3,7 @@
>>    statistics="disable" trace="enable" xmlns="
>> http://wso2.org/carbon/eventformatter">
>>    <from streamName="fault_message" version="1.0.0"/>
>>    <mapping customMapping="enable" type="json">
>> -
>>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","network_partition_id":"{{network_partition_id}}","member_id":"{{member_id}}"}}</inline>
>> +
>>  <inline>{"member_fault":{"cluster_id":"{{cluster_id}}","partition_id":"{{partition_id}}","member_id":"{{member_id}}"}}</inline>
>>    </mapping>
>>    <to eventAdaptorName="JMSOutputAdaptor" eventAdaptorType="jms">
>>      <property
>> name="transport.jms.Destination">summarized-health-stats</property>
>>
>>


-- 
--
Lahiru Sandaruwan
Software Engineer,
Platform Technologies,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware

email: lahirus@wso2.com cell: (+94) 773 325 954
blog: http://lahiruwrites.blogspot.com/
twitter: http://twitter.com/lahirus
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146