You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Norman Maurer (JIRA)" <ji...@apache.org> on 2010/10/19 10:32:41 UTC
[jira] Created: (AMQ-2988) Allow to retrieve the JMSProperties when
using JMS Stream (ActiveMQInputStream)
Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
-------------------------------------------------------------------------------
Key: AMQ-2988
URL: https://issues.apache.org/activemq/browse/AMQ-2988
Project: ActiveMQ
Issue Type: Improvement
Components: Broker
Reporter: Norman Maurer
When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62785#action_62785 ]
Timothy Bish commented on AMQ-2988:
-----------------------------------
Would be nice if you could add some unit tests along with these changes.
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Attachments: ActiveMQInputStream_JMSProps.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQ-2988:
---------------------------------
Assignee: Timothy Bish
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Assignee: Timothy Bish
> Fix For: 5.5.0
>
> Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-2988.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.5.0
Patch applied with modifications to make the properties map unmodifiable and use the generic Collections.emptyMap method instead of creating a new empty map. Thanks.
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Assignee: Timothy Bish
> Fix For: 5.5.0
>
> Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Norman Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62786#action_62786 ]
Norman Maurer commented on AMQ-2988:
------------------------------------
Sure, will add some tomorrow or monday
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Attachments: ActiveMQInputStream_JMSProps.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on AMQ-2988 started by Timothy Bish.
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Assignee: Timothy Bish
> Fix For: 5.5.0
>
> Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2988) Allow to retrieve the JMSProperties when
using JMS Stream (ActiveMQInputStream)
Posted by "Norman Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated AMQ-2988:
-------------------------------
Attachment: ActiveMQInputStream_JMSProps.diff
Here is a patch to add the method
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Attachments: ActiveMQInputStream_JMSProps.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2988) Allow to retrieve the JMSProperties
when using JMS Stream (ActiveMQInputStream)
Posted by "Norman Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62827#action_62827 ]
Norman Maurer commented on AMQ-2988:
------------------------------------
Thx a bunch!
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Assignee: Timothy Bish
> Fix For: 5.5.0
>
> Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2988) Allow to retrieve the JMSProperties when
using JMS Stream (ActiveMQInputStream)
Posted by "Norman Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated AMQ-2988:
-------------------------------
Attachment: AMQ-2988_junit.diff
Add junit test
> Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream)
> -------------------------------------------------------------------------------
>
> Key: AMQ-2988
> URL: https://issues.apache.org/activemq/browse/AMQ-2988
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Reporter: Norman Maurer
> Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff
>
>
> When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it.
> So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.