You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Phabricator (JIRA)" <ji...@apache.org> on 2013/01/16 13:02:15 UTC

[jira] [Commented] (HIVE-3904) Replace hashmaps in JoinOperators to array

    [ https://issues.apache.org/jira/browse/HIVE-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554967#comment-13554967 ] 

Phabricator commented on HIVE-3904:
-----------------------------------

njain has commented on the revision "HIVE-3904 [jira] Replace hashmaps in JoinOperators to array".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java:212 Why is this if check needed ?

  I mean, it was not there previously- why should changing the hashmap to an array
  change anything.

REVISION DETAIL
  https://reviews.facebook.net/D7959

To: JIRA, navis
Cc: njain

                
> Replace hashmaps in JoinOperators to array
> ------------------------------------------
>
>                 Key: HIVE-3904
>                 URL: https://issues.apache.org/jira/browse/HIVE-3904
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3904.D7959.1.patch
>
>
> Join operator has many HashMaps that maps tag to some internal value(ExprEvals, OIs, etc.) and theses are accessed 5 or more times per an object, which is seemed unnecessary overhead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira