You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/14 00:34:03 UTC
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10052: Complete Oracle drop table partition grammar
wgy8283335 commented on a change in pull request #10052:
URL: https://github.com/apache/shardingsphere/pull/10052#discussion_r612857901
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -941,9 +945,51 @@ addListPartitionClause
;
dropTablePartition
- : DROP partitionExtendedNames
+ : DROP partitionExtendedNames (updateIndexClauses parallelClause?)?
;
partitionExtendedNames
- : (PARTITION | PARTITIONS) partition
+ : (PARTITION | PARTITIONS) (partitionName | partitionForClauses) (COMMA_ (partitionName | partitionForClauses))*
+ ;
+
+partitionForClauses
+ : FOR LP_ partitionKeyValue (COMMA_ partitionKeyValue)* RP_
+ ;
+
+updateIndexClauses
+ : updateGlobalIndexClause | updateAllIndexesClause
+ ;
+
+updateGlobalIndexClause
+ : (UPDATE | INVALIDATE) GLOBAL INDEXES
+ ;
+
+updateAllIndexesClause
+ : UPDATE INDEXES
+ (LP_ indexName LP_ (updateIndexPartition | updateIndexSubpartition)
+ (COMMA_ indexName LP_ (updateIndexPartition | updateIndexSubpartition) RP_)* RP_)?
+ ;
+
+updateIndexPartition
+ : indexPartitionDesc indexSubpartitionClause?
+ (COMMA_ indexPartitionDesc indexSubpartitionClause?)*
+ ;
+
+indexPartitionDesc
+ : PARTITION
+ (partitionName
+ ((segmentAttributesClause | indexCompression) | PARAMETERS LP_ SQ_ odciParameters SQ_ RP_ )?
Review comment:
The rule is not correct.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -941,9 +945,51 @@ addListPartitionClause
;
dropTablePartition
- : DROP partitionExtendedNames
+ : DROP partitionExtendedNames (updateIndexClauses parallelClause?)?
;
partitionExtendedNames
- : (PARTITION | PARTITIONS) partition
+ : (PARTITION | PARTITIONS) (partitionName | partitionForClauses) (COMMA_ (partitionName | partitionForClauses))*
+ ;
+
+partitionForClauses
+ : FOR LP_ partitionKeyValue (COMMA_ partitionKeyValue)* RP_
+ ;
+
+updateIndexClauses
+ : updateGlobalIndexClause | updateAllIndexesClause
+ ;
+
+updateGlobalIndexClause
+ : (UPDATE | INVALIDATE) GLOBAL INDEXES
+ ;
+
+updateAllIndexesClause
+ : UPDATE INDEXES
+ (LP_ indexName LP_ (updateIndexPartition | updateIndexSubpartition)
Review comment:
The rule has the wrong number of RP_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org