[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #22: modify consul demo to support makefile

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22#discussion_r541815325



##########
File path: registry/servicediscovery/consul/go-client/pkg/user.go
##########
@@ -15,25 +15,13 @@
  * limitations under the License.
  */
 
-package main
+package pkg

Review comment:
       maybe u can change the dir name. 'pkg' is not so good.

##########
File path: registry/servicediscovery/consul/go-client/cmd/client.go
##########
@@ -20,6 +20,8 @@ package main
 import (
 	"context"
 	"fmt"
+	hessian "github.com/apache/dubbo-go-hessian2"
+	"github.com/apache/dubbo-go-samples/registry/servicediscovery/consul/go-client/pkg"

Review comment:
       the same as above.

##########
File path: registry/servicediscovery/consul/go-client/cmd/client.go
##########
@@ -20,6 +20,8 @@ package main
 import (
 	"context"
 	"fmt"
+	hessian "github.com/apache/dubbo-go-hessian2"

Review comment:
       hey, guy, move it, pls.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org