You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/22 10:18:02 UTC

[GitHub] [pulsar] kezhenxu94 opened a new pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

kezhenxu94 opened a new pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877


   Resolves #7749
   
   ### Motivation
   At the moment, building Pulsar from source codes with maven requires a locally-installed maven, but there are cases that the developers' maven version is not compatible with the one Pulsar uses, this pull request introduces a wrapper of maven, which downloads the specific version of maven on the fly and gets rid of maven versions issues like #7749
   
   ### Modifications
   Add maven wrapper, and modify the doc and CI script to use it
   
   ### Verifying this change
   Build from source codes with maven wrapper successfully, and the CI checks should pass
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] kezhenxu94 commented on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877#issuecomment-682331356


   closing as no response


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877#issuecomment-679392426


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] kezhenxu94 commented on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877#issuecomment-679456275


   Seems the `Sql` case is really flaky


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] kezhenxu94 removed a comment on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
kezhenxu94 removed a comment on pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877#issuecomment-678623175


   I just got interested in the Pulsar project, and am wondering this kind of contribution is welcome or not :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] kezhenxu94 commented on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877#issuecomment-678623175


   I just got interested in the Pulsar project, and am wondering this kind of contribution is welcome or not :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] kezhenxu94 closed pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed pull request #7877:
URL: https://github.com/apache/pulsar/pull/7877


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org