You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/21 10:34:33 UTC
[GitHub] [solr] jaceq opened a new pull request #465: SOLR-15501: GCSBackupRepository operations without credentials
jaceq opened a new pull request #465:
URL: https://github.com/apache/solr/pull/465
https://issues.apache.org/jira/browse/SOLR-15501
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR-
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Given that access to GCS buckets from within Google Cloud Platform can be configured based on roles and not on passwords, it is now possible to use GCSBackupRepository plugin to work also in case when no credentials are given.
This works 'automatically' given that google libraries are used and they support this 'out of the box'
# Solution
Simply allow no credentials to be given.
# Tests
A test to run 'without credentials' is added.
I have also built this and manually tested within GCP environment a BACKUP and RESTORE calls (after obviously configuring the plugin) and they do work as expected.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] linuxswords commented on pull request #465: SOLR-15501: GCSBackupRepository operations without credentials
Posted by GitBox <gi...@apache.org>.
linuxswords commented on pull request #465:
URL: https://github.com/apache/solr/pull/465#issuecomment-1001405654
CC: @gerlowskija (as a Ticket assignee)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija closed pull request #465: SOLR-15501: GCSBackupRepository operations without credentials
Posted by GitBox <gi...@apache.org>.
gerlowskija closed pull request #465:
URL: https://github.com/apache/solr/pull/465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #465: SOLR-15501: GCSBackupRepository operations without credentials
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #465:
URL: https://github.com/apache/solr/pull/465#issuecomment-1010192031
Hey guys, sorry for the delay - the code here looks great. I'm going to test this out as a part of my own workflow in GKE and then I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jaceq commented on pull request #465: SOLR-15501: GCSBackupRepository operations without credentials
Posted by GitBox <gi...@apache.org>.
jaceq commented on pull request #465:
URL: https://github.com/apache/solr/pull/465#issuecomment-998669161
a 'branch 8.11' commit is here: https://github.com/apache/lucene-solr/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org