You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Xavier HAUSHERR (JIRA)" <ji...@apache.org> on 2012/05/28 11:50:22 UTC
[jira] [Created] (THRIFT-1615) Thrift for Symfony 2
Xavier HAUSHERR created THRIFT-1615:
---------------------------------------
Summary: Thrift for Symfony 2
Key: THRIFT-1615
URL: https://issues.apache.org/jira/browse/THRIFT-1615
Project: Thrift
Issue Type: Improvement
Components: PHP - Compiler, PHP - Library
Affects Versions: 0.8, 0.9
Reporter: Xavier HAUSHERR
Fix For: 0.9, 0.8
Hi,
In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
namespaced your PHP Lib (phpsf2)
added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
I have done this in the 0.8x branch (stable version) and in your trunk.
I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
Feel free to send me any question, any feedback on my pull request.
Best regards.
Xavier HAUSHERR
Overblog CTO
@xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414622#comment-13414622 ]
Xavier HAUSHERR edited comment on THRIFT-1615 at 7/15/12 12:48 PM:
-------------------------------------------------------------------
Hi,
Here is my latest patch (thrift.patch) without Symfony Autoloader.
The patch is up to date with your last commit "Thrift-1652: TSaslTransport does not log the error when kerberos auth…" (1361615)
I have create my own autoloader, and added the possibility to autoload Thrift generated definition files. I have added APC cache possibility too to keep good performances.
You can see examples on Unit Tests.
I hope you enjoy this one.
Tell me if you have any question or if you wan't some changes.
was (Author: xkobal):
Hi,
Here is my latest patch without Symfony Autoloader.
The patch is up to date with your last commit "Thrift-1652: TSaslTransport does not log the error when kerberos auth…" (1361615)
I have create my own autoloader, and added the possibility to autoload Thrift generated definition files. I have added APC cache possibility too to keep good performances.
You can see examples on Unit Tests.
I hope you enjoy this one.
Tell me if you have any question or if you wan't some changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch, thrift.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438745#comment-13438745 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
Hello,
Any news about integration of my work in Thrift trunk, or is there some problems with my code ?
Best regards.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402128#comment-13402128 ]
Roger Meier commented on THRIFT-1615:
-------------------------------------
Thank's Xavier!
The only concern I have is the bundled Symfony classloader and the new dependency on this.
Is there an alternative to the Symfony classloader?
Or is it possible to get a class loader under Apache 2 License as part of Thrift?
-roger
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift-2012-09-05.patch
Here is a little patch to fix PHP compilator (Missing an inclusion).
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: (was: thrift.patch)
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1615) PHP Namespace
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier reassigned THRIFT-1615:
-----------------------------------
Assignee: Roger Meier
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Assignee: Roger Meier
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292553#comment-13292553 ]
Roger Meier commented on THRIFT-1615:
-------------------------------------
End of June is perfect!
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Comment: was deleted
(was: Hi,
Here is my latest patch without Symfony Autoloader.
The patch is up to date with your last commit "Thrift-1652: TSaslTransport does not log the error when kerberos auth…" (1361615)
I have create my own autoloader, and added the possibility to autoload Thrift generated definition files. I have added APC cache possibility too to keep good performances.
You can see examples on Unit Tests.
I hope you enjoy this one :D
Tell me if you have any question or if you wan't some changes.)
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287285#comment-13287285 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
I am totally agree with you.
But in this case, are you ok remove the "oop" and "namespace" options too ?
Because namespace is only for > PHP 5.3, and then, generating non-oop or non-namespaced classes became useless ?
What is your opinion on that point ?
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: namespace.patch
Finally, I have finished the patch. You can find it attached to that post. The patch is up to date with your last commit "Adding svn propset ignore for compiler/src/windows/version.h"
What I have done:
- Namespaced the PHP library
- Added Symfony UniversalClassLoader with its license to give developer an autoloader
- Update PHP tutorial and test
- Remove namespace and autoload option from PHP Compiler, and update every code to generate namespace compliant code.
Tell me if you have any question or if you wan't som changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Mike Riley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400194#comment-13400194 ]
Mike Riley commented on THRIFT-1615:
------------------------------------
I was happy to see this patch because I'm working on a SF2 project myself and the bundle / patch here seems to have done the trick. So as far as my project is concerned this is great. A few things though:
It looks like we've clobbered the old classes in the protocol extension, are we ok breaking backwards compatibility there? If we run under the assumption that people using namespaced code are namespacing everywhere, it should be ok to just include all of them (namespaced and non-namespaced) in the protocol build. It's messy because everything is defined twice, but I guess that's the nature of maintaining backwards compatibility.
We could entirely forego using the universal classloader / including those classes with thrift. Instead it might be simpler to just re-implement the method used for loading classes in our own autoloader. This won't prevent SF2 projects from using the classes with the universal classloader and it prevents us from having to add more cruft to the PHP library.
If we're going to document the use of a bundle for SF2 here, would the thrift maintainers consider hosting one themselves rather than having an external maintainer? For the uninitiated: a symfony bundle needs to be maintained in a separate git repository if it's going to integrate properly with symfony's dependency management system.
I'll be using this patch this week and try to give some more feedback on it.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: (was: thrift.patch)
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) PHP Namespace
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-1615:
--------------------------------
Summary: PHP Namespace (was: Thrift for Symfony 2)
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400080#comment-13400080 ]
Xavier HAUSHERR edited comment on THRIFT-1615 at 6/24/12 12:36 AM:
-------------------------------------------------------------------
Finally, I have finished the patch (namespace.patch). You can find it attached to that post. The patch is up to date with your last commit "Adding svn propset ignore for compiler/src/windows/version.h"
What I have done:
- Namespaced the PHP library
- Added Symfony UniversalClassLoader with its license to give developer an autoloader
- Update PHP tutorial and test
- Remove namespace and autoload option from PHP Compiler, and update every code to generate namespace compliant code.
Tell me if you have any question or if you wan't some changes.
was (Author: xkobal):
Finally, I have finished the patch. You can find it attached to that post. The patch is up to date with your last commit "Adding svn propset ignore for compiler/src/windows/version.h"
What I have done:
- Namespaced the PHP library
- Added Symfony UniversalClassLoader with its license to give developer an autoloader
- Update PHP tutorial and test
- Remove namespace and autoload option from PHP Compiler, and update every code to generate namespace compliant code.
Tell me if you have any question or if you wan't some changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409711#comment-13409711 ]
Jake Farrell commented on THRIFT-1615:
--------------------------------------
The autoloader included with the Thrift php lib should be Symfony independent so users are not forced to use that framework
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift.patch
Hi,
Here is my latest patch without Symfony Autoloader.
The patch is up to date with your last commit "Thrift-1652: TSaslTransport does not log the error when kerberos auth…" (1361615)
I have create my own autoloader, and added the possibility to autoload Thrift generated definition files. I have added APC cache possibility too to keep good performances.
You can see examples on Unit Tests.
I hope you enjoy this one.
Tell me if you have any question or if you wan't some changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch, thrift.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) PHP Namespace
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449112#comment-13449112 ]
Hudson commented on THRIFT-1615:
--------------------------------
Integrated in Thrift #524 (See [https://builds.apache.org/job/Thrift/524/])
THRIFT-1615
cleanup: remove empty stuff (Revision 1381333)
THRIFT-1615 PHP Namespace (was Thrift for Symfony 2)
Patch: Xavier HAUSHERR (Revision 1381323)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1381333
Files :
* /thrift/trunk/lib/php/src/protocol
* /thrift/trunk/lib/php/src/server
* /thrift/trunk/lib/php/src/transport
roger : http://svn.apache.org/viewvc/?view=rev&rev=1381323
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc
* /thrift/trunk/lib/php/Makefile.am
* /thrift/trunk/lib/php/README
* /thrift/trunk/lib/php/README.apache
* /thrift/trunk/lib/php/lib
* /thrift/trunk/lib/php/lib/Thrift
* /thrift/trunk/lib/php/lib/Thrift/Base
* /thrift/trunk/lib/php/lib/Thrift/Base/TBase.php
* /thrift/trunk/lib/php/lib/Thrift/ClassLoader
* /thrift/trunk/lib/php/lib/Thrift/ClassLoader/ThriftClassLoader.php
* /thrift/trunk/lib/php/lib/Thrift/Exception
* /thrift/trunk/lib/php/lib/Thrift/Exception/TApplicationException.php
* /thrift/trunk/lib/php/lib/Thrift/Exception/TException.php
* /thrift/trunk/lib/php/lib/Thrift/Exception/TProtocolException.php
* /thrift/trunk/lib/php/lib/Thrift/Exception/TTransportException.php
* /thrift/trunk/lib/php/lib/Thrift/Factory
* /thrift/trunk/lib/php/lib/Thrift/Factory/TBinaryProtocolFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Factory/TCompactProtocolFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Factory/TJSONProtocolFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Factory/TProtocolFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Factory/TStringFuncFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Factory/TTransportFactory.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol
* /thrift/trunk/lib/php/lib/Thrift/Protocol/JSON
* /thrift/trunk/lib/php/lib/Thrift/Protocol/JSON/BaseContext.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/JSON/ListContext.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/JSON/LookaheadReader.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/JSON/PairContext.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/TBinaryProtocol.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/TCompactProtocol.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/TJSONProtocol.php
* /thrift/trunk/lib/php/lib/Thrift/Protocol/TProtocol.php
* /thrift/trunk/lib/php/lib/Thrift/Serializer
* /thrift/trunk/lib/php/lib/Thrift/Serializer/TBinarySerializer.php
* /thrift/trunk/lib/php/lib/Thrift/Server
* /thrift/trunk/lib/php/lib/Thrift/Server/TForkingServer.php
* /thrift/trunk/lib/php/lib/Thrift/Server/TServer.php
* /thrift/trunk/lib/php/lib/Thrift/Server/TServerSocket.php
* /thrift/trunk/lib/php/lib/Thrift/Server/TServerTransport.php
* /thrift/trunk/lib/php/lib/Thrift/Server/TSimpleServer.php
* /thrift/trunk/lib/php/lib/Thrift/StringFunc
* /thrift/trunk/lib/php/lib/Thrift/StringFunc/Core.php
* /thrift/trunk/lib/php/lib/Thrift/StringFunc/Mbstring.php
* /thrift/trunk/lib/php/lib/Thrift/StringFunc/TStringFunc.php
* /thrift/trunk/lib/php/lib/Thrift/Transport
* /thrift/trunk/lib/php/lib/Thrift/Transport/TBufferedTransport.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TFramedTransport.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/THttpClient.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TMemoryBuffer.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TNullTransport.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TPhpStream.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TSocket.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TSocketPool.php
* /thrift/trunk/lib/php/lib/Thrift/Transport/TTransport.php
* /thrift/trunk/lib/php/lib/Thrift/Type
* /thrift/trunk/lib/php/lib/Thrift/Type/TMessageType.php
* /thrift/trunk/lib/php/lib/Thrift/Type/TType.php
* /thrift/trunk/lib/php/src/protocol/TBinaryProtocol.php
* /thrift/trunk/lib/php/src/protocol/TBinarySerializer.php
* /thrift/trunk/lib/php/src/protocol/TCompactProtocol.php
* /thrift/trunk/lib/php/src/protocol/TJSONProtocol.php
* /thrift/trunk/lib/php/src/protocol/TProtocol.php
* /thrift/trunk/lib/php/src/server/TForkingServer.php
* /thrift/trunk/lib/php/src/server/TServer.php
* /thrift/trunk/lib/php/src/server/TSimpleServer.php
* /thrift/trunk/lib/php/src/transport/TBufferedTransport.php
* /thrift/trunk/lib/php/src/transport/TFramedTransport.php
* /thrift/trunk/lib/php/src/transport/THttpClient.php
* /thrift/trunk/lib/php/src/transport/TMemoryBuffer.php
* /thrift/trunk/lib/php/src/transport/TNullTransport.php
* /thrift/trunk/lib/php/src/transport/TPhpStream.php
* /thrift/trunk/lib/php/src/transport/TServerSocket.php
* /thrift/trunk/lib/php/src/transport/TServerTransport.php
* /thrift/trunk/lib/php/src/transport/TSocket.php
* /thrift/trunk/lib/php/src/transport/TSocketPool.php
* /thrift/trunk/lib/php/src/transport/TTransport.php
* /thrift/trunk/lib/php/src/transport/TTransportFactory.php
* /thrift/trunk/lib/php/test/Makefile.am
* /thrift/trunk/lib/php/test/Test
* /thrift/trunk/lib/php/test/Test/Thrift
* /thrift/trunk/lib/php/test/Test/Thrift/Fixtures.php
* /thrift/trunk/lib/php/test/Test/Thrift/Protocol
* /thrift/trunk/lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php
* /thrift/trunk/test/php/TestClient.php
* /thrift/trunk/tutorial/php/PhpClient.php
* /thrift/trunk/tutorial/php/PhpServer.php
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Assignee: Roger Meier
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284599#comment-13284599 ]
Jake Farrell commented on THRIFT-1615:
--------------------------------------
I think moving to a more namespace compliant layout is the better approach rather than having a copy of a library
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284353#comment-13284353 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
I know my lib/phpsf is a problem because the code is exactly the same as lib/php, but lib/php doesn't use Namespace as Symfony 2 or PHP 5.3 does.
So it is a real problem for being PHP 5.3 fully compliant. But I know the problem is to maintain 2 times the same code.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399133#comment-13399133 ]
Jake Farrell commented on THRIFT-1615:
--------------------------------------
Any updates on this ticket? Getting ready to create 0.9 release candidate
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1615) PHP Namespace
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1615.
---------------------------------
Resolution: Fixed
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Assignee: Roger Meier
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448776#comment-13448776 ]
Xavier HAUSHERR edited comment on THRIFT-1615 at 9/6/12 1:31 AM:
-----------------------------------------------------------------
Here is a little patch to fix PHP compilator (Missing an inclusion).
=> thrift-2012-09-05.patch
was (Author: xkobal):
Here is a little patch to fix PHP compilator (Missing an inclusion).
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399151#comment-13399151 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
I'm working on it. Work is almost 50% done.
I need to update tests and to clean PHP compiler.
As I say in previous comment, it will be ready for end of June.
Can you wait until that date to release RC ?
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift-trunk-phpsf2.patch
Here is my patch for trunk version.
I have merged code today at 11AM (paris hour)
My working copy is here: https://github.com/ebuzzing/thrift
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift-0.8.x-phpsf2.patch
And the patch for the 0.8.x version.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) PHP Namespace
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449054#comment-13449054 ]
Roger Meier commented on THRIFT-1615:
-------------------------------------
Thanks Xavier!
reviewed and committed.
;-r
and sorry for the delay...
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Assignee: Roger Meier
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290959#comment-13290959 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
OK, let's go :D
I will remove these options (oop/namespace/sf2) from PHP compiler and create a oop/namespaced default version of the PHP compiler.
Do you have any milestone for the release ? How many time do I have ? I think end of june is a correct date for me.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410109#comment-13410109 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
As I said before, the Autoloader component is totally free from Symfony.
But, OK, I am going to create another one.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400080#comment-13400080 ]
Xavier HAUSHERR edited comment on THRIFT-1615 at 6/24/12 12:35 AM:
-------------------------------------------------------------------
Finally, I have finished the patch. You can find it attached to that post. The patch is up to date with your last commit "Adding svn propset ignore for compiler/src/windows/version.h"
What I have done:
- Namespaced the PHP library
- Added Symfony UniversalClassLoader with its license to give developer an autoloader
- Update PHP tutorial and test
- Remove namespace and autoload option from PHP Compiler, and update every code to generate namespace compliant code.
Tell me if you have any question or if you wan't some changes.
was (Author: xkobal):
Finally, I have finished the patch. You can find it attached to that post. The patch is up to date with your last commit "Adding svn propset ignore for compiler/src/windows/version.h"
What I have done:
- Namespaced the PHP library
- Added Symfony UniversalClassLoader with its license to give developer an autoloader
- Update PHP tutorial and test
- Remove namespace and autoload option from PHP Compiler, and update every code to generate namespace compliant code.
Tell me if you have any question or if you wan't som changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift.patch
Hi,
Here is my latest patch without Symfony Autoloader.
The patch is up to date with your last commit "Thrift-1652: TSaslTransport does not log the error when kerberos auth…" (1361615)
I have create my own autoloader, and added the possibility to autoload Thrift generated definition files. I have added APC cache possibility too to keep good performances.
You can see examples on Unit Tests.
I hope you enjoy this one :D
Tell me if you have any question or if you wan't some changes.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch, thrift.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284546#comment-13284546 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
No problem to use the namespace and oop option.
I have created the sf2 option to avoid breaking compatibility for the actual version.
My real problem is that the actual php lib doesn't allow me to be namespace compliant for Symfony 2.
Here is my guidelines (the one I follow in the phpsf2 library):
- Add a namespace for each class
- Have only one class per file
- Remove the hardcoded inclusion and replace with the "use command"
- Remove the autoloader
Nothing more was done. I have just copy and paste the original classes.
And my update on the compiler was only to follow that guidelines.
And there is no other changes.
So my question is: can I change the library to become really namespace compliant ? What is the limit. If I do that, I will lose the compatibility ith older PHP version.
Tell me how you see that patch and I'll follow your point of view.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400216#comment-13400216 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
- The namespaced version of PHP lib is just for new thrift version (0.9). Maintening two libraries would be something difficult I think.
- I have added the SF2 Autoloader component just to add a good and independent loader, but it is not mandatory to use it. It's just to provide one autoloader.
- If you wan't to use Thrift in SF2 with v0.8, you can use the bundles we create for Overblog:
- https://github.com/ebuzzing/thrift/tree/0.8.x => Thrift fork with namespaced version for v0.8
- https://github.com/ebuzzing/OverblogThriftBundle => The bundle to include thrift in SF2
We use these bundles for Overblog, and it works very well. Feel free to provide any comment.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier HAUSHERR updated THRIFT-1615:
------------------------------------
Attachment: thrift.patch
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch, thrift.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284503#comment-13284503 ]
Roger Meier commented on THRIFT-1615:
-------------------------------------
It seems that the new Symfony 2 does oop and namespace, why do you need another option? just for the namespace includes used within the lib/phpsf ?
thrift compiler options today:
{noformat}
php (PHP):
inlined: Generate PHP inlined files
server: Generate PHP server stubs
autoload: Generate PHP with autoload
oop: Generate PHP with object oriented subclasses
rest: Generate PHP REST processors
namespace: Generate PHP namespaces as defined in PHP >= 5.3
{noformat}
I suggest to refactor the php lib to the namespace layout first. I think this is something that many people would like to use.
The sf2 compiler option might then become obsolete, just use oop and namespace.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) PHP Namespace
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449162#comment-13449162 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
Great news, I can now remove my fork and go back to trunk !
Thank you very much.
> PHP Namespace
> -------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Assignee: Roger Meier
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-2012-09-05.patch, thrift.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Xavier HAUSHERR (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402164#comment-13402164 ]
Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------
This is not a dependency, just an inclusion off the Autoloader Component (not the entire Symfony) which is a totally independent class.
Symfony is under BSD license.
I can create another Autoloader, but the Symfony Autoloader works really well, and it follow the PSR specification.
And anyone can create another autoloader, and not use the Symfony one.
If you really wan't another one, I can search or create one.
Tell me what is the best for your.
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.9
>
> Attachments: namespace.patch, thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289666#comment-13289666 ]
Roger Meier commented on THRIFT-1615:
-------------------------------------
Many distributions have PHP > 5.3 (e.g. Debian uses PHP 5.3.3-7+squeeze9)
I think it is worth to make oop and namespace the standard for php Thrift library.
The oop and namespace options can be removed from the compiler.
... test/php and tutorial/php/ needs some adoption as well;-)
> Thrift for Symfony 2
> --------------------
>
> Key: THRIFT-1615
> URL: https://issues.apache.org/jira/browse/THRIFT-1615
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.8, 0.9
> Reporter: Xavier HAUSHERR
> Labels: improvement, php, symfony2
> Fix For: 0.8, 0.9
>
> Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira