You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2011/08/08 04:36:26 UTC
svn commit: r1154809 - /httpd/httpd/branches/2.2.x/STATUS
Author: covener
Date: Mon Aug 8 02:36:25 2011
New Revision: 1154809
URL: http://svn.apache.org/viewvc?rev=1154809&view=rev
Log:
get some quick votes in, double-check change of relative-redirect loglevel change.
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1154809&r1=1154808&r2=1154809&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Mon Aug 8 02:36:25 2011
@@ -121,30 +121,33 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
linked modules.)
PR: 45076
2.2.x patch: http://people.apache.org/~trawick/1032002-2.2.x.txt
- +1: trawick, sf
+ +1: trawick, sf, covener
* Adjust inflated log severity.
PR: 44020
Trunk patch: Was never in trunk.
2.2.x patch: http://people.apache.org/~sf/PR44020.diff
+1: sf
+ +0: covener did you see Jim's initial concern on introducing the
+ ap_construct_url() in maintenance? This dissuaded me from
+ proposing the same.
* mod_deflate: Stop compressing HEAD requests if there is not Content-Length
header
Trunk patch: http://svn.apache.org/viewvc?rev=958253&view=rev
2.2.x patch: trunk patch works with offset
- +1: sf
+ +1: sf, covener
* mod_reqtimeout: Disable keep-alive after read timeout
Trunk patch: http://svn.apache.org/viewvc?rev=1103213&view=rev
2.2.x patch: trunk patch works except for CHANGES
- +1: sf
+ +1: sf, covener
* mod_authnz_ldap: Treat 'constraint violation' as auth denied, not as
internal server error.
Trunk patch: http://svn.apache.org/viewvc?rev=1125646&view=rev
2.2.x patch: trunk patch works except for CHANGES
- +1: sf
+ +1: sf, covener
* mod_filter: fix parsing of regexps containing slashes
PR 51434 (and 51435, which includes the fix)
Re: svn commit: r1154809 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Saturday 13 August 2011, Eric Covener wrote:
> Sorry should have included -- Referring to commit message here:
> http://svn.apache.org/viewvc?view=revision&revision=791541
>
> NOTE: I'm recommending different versions because the trunk
> patch is too strict for a stable line and may "break" broken
> configs thought by their users to be working.
>
> But, we never provided a way to suppress it, and we've never heard
> a peep about being broken AND seeing the WARN message AFAIK.
I think that was mainly refering to the fact that in the
!ap_is_url(ret) case, the trunk version returns internal server error
while the 2.2 version just does nothing. In that case, there is a log
message with level error, but that is not the one I want to change.
I think the different log levels for the "incomplete redirection
target" message were just an oversight. It really should have been
debug in the 2.2 version, too.
Re: svn commit: r1154809 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Eric Covener <co...@gmail.com>.
On Sat, Aug 13, 2011 at 5:33 PM, Stefan Fritsch <sf...@sfritsch.de> wrote:
> On Mon, 8 Aug 2011, covener@apache.org wrote:
>
>> Author: covener
>> Date: Mon Aug 8 02:36:25 2011
>> New Revision: 1154809
>>
>> URL: http://svn.apache.org/viewvc?rev=1154809&view=rev
>> Log:
>> get some quick votes in, double-check change of relative-redirect loglevel
>> change.
>>
>>
>> Modified:
>> httpd/httpd/branches/2.2.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.2.x/STATUS
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1154809&r1=1154808&r2=1154809&view=diff
>>
>> ==============================================================================
>> --- httpd/httpd/branches/2.2.x/STATUS (original)
>> +++ httpd/httpd/branches/2.2.x/STATUS Mon Aug 8 02:36:25 2011
>
>
>> * Adjust inflated log severity.
>> PR: 44020
>> Trunk patch: Was never in trunk.
>> 2.2.x patch: http://people.apache.org/~sf/PR44020.diff
>> +1: sf
>> + +0: covener did you see Jim's initial concern on introducing the
>> + ap_construct_url() in maintenance? This dissuaded me from
>> + proposing the same.
>
> No, I didn't. Can you give a pointer, I didn't find it? Or did you mean
> Nick's comment in PR 44020? That was only about what to do if
> ap_construct_url() fails to create a valid URL.
>
Sorry should have included -- Referring to commit message here:
http://svn.apache.org/viewvc?view=revision&revision=791541
NOTE: I'm recommending different versions because the trunk
patch is too strict for a stable line and may "break" broken
configs thought by their users to be working.
But, we never provided a way to suppress it, and we've never heard a
peep about being broken AND seeing the WARN message AFAIK.
--
Eric Covener
covener@gmail.com
Re: svn commit: r1154809 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Mon, 8 Aug 2011, covener@apache.org wrote:
> Author: covener
> Date: Mon Aug 8 02:36:25 2011
> New Revision: 1154809
>
> URL: http://svn.apache.org/viewvc?rev=1154809&view=rev
> Log:
> get some quick votes in, double-check change of relative-redirect loglevel change.
>
>
> Modified:
> httpd/httpd/branches/2.2.x/STATUS
>
> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1154809&r1=1154808&r2=1154809&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Mon Aug 8 02:36:25 2011
> * Adjust inflated log severity.
> PR: 44020
> Trunk patch: Was never in trunk.
> 2.2.x patch: http://people.apache.org/~sf/PR44020.diff
> +1: sf
> + +0: covener did you see Jim's initial concern on introducing the
> + ap_construct_url() in maintenance? This dissuaded me from
> + proposing the same.
No, I didn't. Can you give a pointer, I didn't find it? Or did you mean
Nick's comment in PR 44020? That was only about what to do if
ap_construct_url() fails to create a valid URL.