You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Stig Rohde Døssing (JIRA)" <ji...@apache.org> on 2019/06/01 09:16:00 UTC

[jira] [Commented] (STORM-3071) change checkstyle plugin setting logViolationsToConsole to true

    [ https://issues.apache.org/jira/browse/STORM-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853640#comment-16853640 ] 

Stig Rohde Døssing commented on STORM-3071:
-------------------------------------------

The reason we don't log violations to console is that we have a lot of violations in some modules, that were grandfathered in when we added Checkstyle to the build. I agree that there's no point to hiding errors in modules where the errors are new, but printing all violations to console for the modules with grandfathered violations would make the build log unreadable.

It would be fine IMO to enable logViolationsToConsole for modules that currently have maxAllowedViolations set to 0.

> change checkstyle plugin setting logViolationsToConsole to true
> ---------------------------------------------------------------
>
>                 Key: STORM-3071
>                 URL: https://issues.apache.org/jira/browse/STORM-3071
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Karl Richter
>            Priority: Major
>
> There's no value in hiding the details of checkstyle warnings and errors with `logViolationsToConsole`, so it should be `true`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)