You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "och5351 (via GitHub)" <gi...@apache.org> on 2026/07/19 05:36:29 UTC
[PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
och5351 opened a new pull request, #4436:
URL: https://github.com/apache/streampark/pull/4436
## What is the purpose of the change
Implements [#4435](https://github.com/apache/streampark/issues/4435) — Phase 0.1 of the Scala removal plan ([#4408](https://github.com/apache/streampark/issues/4408)).
Introduces a pure-Java `streampark-flink-core` module and defines `FlinkStreamingJob` as the Java abstract base class that replaces the deleted Scala `FlinkStreaming` trait.
## Brief change log
- Add new Maven module `streampark-flink/streampark-flink-core` (no Scala version suffix, no Scala dependencies)
- Define `FlinkStreamingJob` abstract class with lifecycle: `configure → ready → handle → execute → destroy`
- Register the new module in `streampark-flink/pom.xml`
- Add JUnit 5 tests verifying lifecycle order, class name default, and `ParameterTool` propagation
## Verifying this change
```bash
mvn test -pl streampark-flink/streampark-flink-core
```
Tests run: 3, Failures: 0, Errors: 0
## Does this pull request potentially affect one of the following parts?
- [x] The public API
- [ ] The web application
- [ ] The build system
## Documentation
- Relates to issue [#4435](https://github.com/apache/streampark/issues/4435)
- Part of umbrella issue [#4408](https://github.com/apache/streampark/issues/4408)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5014932276
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5014890489
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "shangeyao (via GitHub)" <gi...@apache.org>.
shangeyao commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5019742358
Thanks for picking up #4408 Phase 0.1 — the scoped approach and lifecycle tests look good.
Before merge, I think we need closer parity with the old `FlinkStreaming` platform contract:
1. **Init path** — Wire init through `FlinkStreamingInitializer` (or an equivalent Java port): `--conf`, `setAppHome`, merged `ParameterTool` / `FlinkConfiguration`. The current `ParameterTool.fromArgs()` + bare `StreamExecutionEnvironment.getExecutionEnvironment()` won't work for Console-submitted jobs.
2. **App name** — Use StreamPark app-name resolution (`getAppName` semantics: `app.name`, `pipeline.name`, deflate), not only raw `parameter.get("app.name", ...)`. The existing test doesn't verify the name passed to `execute()`.
3. **`main()` entry** — Console launches user `mainClass`; the old trait provided `main()`. Please document or provide a standard entry pattern for `FlinkStreamingJob`.
4. **Context vs #4432** — Clarify in the PR description that this reintroduces `streampark-flink-core` as the **Java replacement** after #4432, per #4408 — not a rollback.
Non-blocking: consider `finally` for `destroy()`, align package name with #4408 (`core.java`?), add `streampark-common` (provided), and update `AGENTS.md` when this lands.
Happy to re-review once the blocking items are addressed. +1 on phased follow-ups for `FlinkTable` / `FlinkStreamTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "och5351 (via GitHub)" <gi...@apache.org>.
och5351 commented on code in PR #4436:
URL: https://github.com/apache/streampark/pull/4436#discussion_r3610553662
##########
streampark-flink/streampark-flink-core/src/main/java/org/apache/streampark/flink/core/FlinkStreamingJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.streampark.flink.core;
+
+import org.apache.flink.api.common.JobExecutionResult;
+import org.apache.flink.api.java.utils.ParameterTool;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+
+public abstract class FlinkStreamingJob {
Review Comment:
Thank you for the review @wolfboys !
1. Regarding FlinkStreamTable and FlinkTable — this PR intentionally covers only Phase 0.1 of the #4408 roadmap, limiting the scope to FlinkStreamingJob. The remaining classes are planned for subsequent phases. I apologize if that context wasn't clear enough in the PR description. If my approach is off track, I would really appreciate your feedback.
2. Regarding the difference from the Scala version — the lifecycle structure (init → ready → handle → execute → destroy) follows the original. The differences are intentional: since FlinkStreamingInitializer and StreamingContext are themselves Scala components targeted for removal in later phases, the Java version uses Flink's standard APIs directly instead of depending on them. This was a deliberate decision to avoid StreamPark's own wrapper classes, but I'd love your thoughts on whether this direction is the right one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5064593924
Thank you for your valuable contribution.
After careful evaluation, we found that the current PR introduces significant changes compared with the existing implementation and may impact the original design and migration approach. To ensure a minimal, stable, and manageable migration process, the PMC has discussed and reviewed the proposal, and we have redefined the roadmap for removing Scala.
Currently, we plan to proceed with Stage 1 — Flink Core, migrating modules incrementally according to the proposed execution plan(Principle: no logic changes; migrate modules to Java with readable, idiomatic code). We kindly suggest following the steps outlined in the issue: [flink core](https://github.com/apache/streampark/issues/4408)
Thanks again for your effort and contribution. We look forward to continuing the collaboration on this migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #4436:
URL: https://github.com/apache/streampark/pull/4436#discussion_r3610406606
##########
streampark-flink/streampark-flink-core/.flattened-pom.xml:
##########
Review Comment:
Could you please check if the .flattened-pom.xml file is needs to be committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "och5351 (via GitHub)" <gi...@apache.org>.
och5351 commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5075842404
@wolfboys
Thanks for providing the roadmap. I'll begin with issue #4445 and work on making meaningful contributions to the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5014579193
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5014908854
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5015733016
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #4436:
URL: https://github.com/apache/streampark/pull/4436#discussion_r3610402386
##########
streampark-flink/streampark-flink-core/src/main/java/org/apache/streampark/flink/core/FlinkStreamingJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.streampark.flink.core;
+
+import org.apache.flink.api.common.JobExecutionResult;
+import org.apache.flink.api.java.utils.ParameterTool;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+
+public abstract class FlinkStreamingJob {
Review Comment:
We greatly appreciate your contribution. I have observed that the current Java implementation differs considerably from the Scala version, and that several core classes (FlinkStreamTable, FlinkTable) are not yet updated. The recommendation is to keep the original Scala module's logic unchanged and only reimplement it in Java, which would reduce the risk to a minimum. Subsequent iterations and modifications can be made thereafter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4436:
URL: https://github.com/apache/streampark/pull/4436#issuecomment-5015741832
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4436&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4436&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Define FlinkStreamingJob Java lifecycle base class [streampark]
Posted by "och5351 (via GitHub)" <gi...@apache.org>.
och5351 commented on code in PR #4436:
URL: https://github.com/apache/streampark/pull/4436#discussion_r3610561225
##########
streampark-flink/streampark-flink-core/.flattened-pom.xml:
##########
Review Comment:
Thank you for your notice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org