You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/13 00:10:50 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated

mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r439685696



##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -662,6 +662,7 @@ public void testInvalidTopicNames() throws Exception {
         }
     }
 
+    @SuppressWarnings("deprecation")

Review comment:
       @cmccabe I think we can keep most of those test as-is until `retries` is removed -- the ones with `@SuppressWarning` should be rewritten if `retries` is removed IMHO, while the ones with `@Deprecated` should be remove. Let me know if this makes sense or if you think we should rewrite those tests right away.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org