[GitHub] [spark] rdblue commented on a change in pull request #24689: [SPARK-26946][SQL][FOLLOWUP] Require lookup function

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24689: [SPARK-26946][SQL][FOLLOWUP] Require lookup function
URL: https://github.com/apache/spark/pull/24689#discussion_r288304534
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -93,22 +97,16 @@ object AnalysisContext {
  * Provides a logical query plan analyzer, which translates [[UnresolvedAttribute]]s and
  * [[UnresolvedRelation]]s into fully typed objects using information in a [[SessionCatalog]].
  */
-class Analyzer(
+abstract class Analyzer(
 
 Review comment:
   Why not continue to pass a lookup function in some paths and default the analyzer to use one that throws `CatalogNotFoundException`? That would avoid a lot of these changes.
   
   ```scala
   class Analyzer(..., catalogLookup: String => CatalogPlugin) {
     def this(...) = {
       this(..., _ => throw new CatalogNotFoundException(...)
     }
   }
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org