You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2015/02/03 19:06:51 UTC
Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java 7a7b28c
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1e13932
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 69c55df
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 6d35143
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 4a7afcf
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java d5cabd0
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71229
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Feb. 5, 2015, 2:59 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 2:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/main/java/org/apache/sqoop/model/ModelError.java dcb137a
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 6:59 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/main/java/org/apache/sqoop/model/ModelError.java dcb137a
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 2b5a9b7
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 6:55 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/main/java/org/apache/sqoop/model/ModelError.java dcb137a
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 2b5a9b7
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > Thank you very much for putting this patch together Veena! Overall I like the approach and have only few questions/comments (mostly real nits):
> >
> > 1) I think that I broke the patch by committing postgresql integration tests:
> >
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[151,19] cannot find symbol
> > [ERROR] symbol : constructor MStringInput(java.lang.String,boolean,short)
> > [ERROR] location: class org.apache.sqoop.model.MStringInput
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[153,12] cannot find symbol
> >
> > 2) I'm slightly worries that we are not doing any defensive checking for the overrides field. We are keeping the "overrides" only as comma separated string and we are not verifying anywhere that it actually contains only valid values (e.g. other configs that do exists). The only place where we are sort of doing that is in the repository where we are actually translating the values to ids, but that seems quite late in the process. Do you think that we could add those checks somewhere sooner? Perhaps to the ConfigUtils class? (e.g. let's fail fast)
>
> Veena Basavaraj wrote:
> it is done when w register the configs/ inserting to the database, wont this cover all paths,?
>
> Veena Basavaraj wrote:
> The word defensive did not make sense to me and confused me, defensive mean we catch the issue and the current code does it, if it a matter of checking this in the config utils and not in repository code, i will move it there, not a big deal.
>
> Jarek Cecho wrote:
> I would definitely put some checks somewhere into the model layer - it can be in addition to the code in repository.
ok in addition is better.:)
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 2:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > Thank you very much for putting this patch together Veena! Overall I like the approach and have only few questions/comments (mostly real nits):
> >
> > 1) I think that I broke the patch by committing postgresql integration tests:
> >
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[151,19] cannot find symbol
> > [ERROR] symbol : constructor MStringInput(java.lang.String,boolean,short)
> > [ERROR] location: class org.apache.sqoop.model.MStringInput
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[153,12] cannot find symbol
> >
> > 2) I'm slightly worries that we are not doing any defensive checking for the overrides field. We are keeping the "overrides" only as comma separated string and we are not verifying anywhere that it actually contains only valid values (e.g. other configs that do exists). The only place where we are sort of doing that is in the repository where we are actually translating the values to ids, but that seems quite late in the process. Do you think that we could add those checks somewhere sooner? Perhaps to the ConfigUtils class? (e.g. let's fail fast)
it is done when w register the configs/ inserting to the database, wont this cover all paths,?
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, line 66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line66>
> >
> > Nit: I know that we had discussion about making it array of objects and decided not to because it would be too complex, but what perhaps array of strings? Like:
> >
> > String [] overrides() default {};
> >
> > We have similar idiom with the validators (it's an array of something), so it seems a bit nicer. I don't feel super strongly about this one though, so if we feel that this is better, I'm fine.
what is the syntax at the config level? and again the odds oof having more than one is unlikely.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java, lines 327-329
> > <https://reviews.apache.org/r/30537/diff/5/?file=846631#file846631line327>
> >
> > I'm not immediately sure why we are removing this fragment?
we shud have done this before, we have a valid driver Id, it does not have to be null, its bad that this even existed so far.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, lines 125-139
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line125>
> >
> > It seems to me that we are storing the same information twice - we have the input names stored in one table and their corresponding ids in second table. I'm wondering if that is necessary?
nto sure i understand, we are storing relation here, so we can infer it
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, line 126
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line126>
> >
> > Can we put somewhere (probably into ConfigUtils) verification code that will ensure that the string is less then the 32 characters? I'm afraid that connector developper will try to use more and "random" things will start happening.
if they use more than 32 chars, the database will throw an exception as it will today for the input name,
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, line 136
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line136>
> >
> > I think that the id here is not adding much value, right? The primary key can be simply (PARENT_ID, CHILD_ID).
@gwem what do you think? it feels weird to m
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 2:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 4, 2015, 10:25 p.m., Jarek Cecho wrote:
> > Thank you very much for putting this patch together Veena! Overall I like the approach and have only few questions/comments (mostly real nits):
> >
> > 1) I think that I broke the patch by committing postgresql integration tests:
> >
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[151,19] cannot find symbol
> > [ERROR] symbol : constructor MStringInput(java.lang.String,boolean,short)
> > [ERROR] location: class org.apache.sqoop.model.MStringInput
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[153,12] cannot find symbol
> >
> > 2) I'm slightly worries that we are not doing any defensive checking for the overrides field. We are keeping the "overrides" only as comma separated string and we are not verifying anywhere that it actually contains only valid values (e.g. other configs that do exists). The only place where we are sort of doing that is in the repository where we are actually translating the values to ids, but that seems quite late in the process. Do you think that we could add those checks somewhere sooner? Perhaps to the ConfigUtils class? (e.g. let's fail fast)
>
> Veena Basavaraj wrote:
> it is done when w register the configs/ inserting to the database, wont this cover all paths,?
>
> Veena Basavaraj wrote:
> The word defensive did not make sense to me and confused me, defensive mean we catch the issue and the current code does it, if it a matter of checking this in the config utils and not in repository code, i will move it there, not a big deal.
I would definitely put some checks somewhere into the model layer - it can be in addition to the code in repository.
> On Feb. 4, 2015, 10:25 p.m., Jarek Cecho wrote:
> > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java, lines 327-329
> > <https://reviews.apache.org/r/30537/diff/5/?file=846631#file846631line327>
> >
> > I'm not immediately sure why we are removing this fragment?
>
> Veena Basavaraj wrote:
> we shud have done this before, we have a valid driver Id, it does not have to be null, its bad that this even existed so far.
Thanks for the explanation.
> On Feb. 4, 2015, 10:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, line 126
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line126>
> >
> > Can we put somewhere (probably into ConfigUtils) verification code that will ensure that the string is less then the 32 characters? I'm afraid that connector developper will try to use more and "random" things will start happening.
>
> Veena Basavaraj wrote:
> if they use more than 32 chars, the database will throw an exception as it will today for the input name,
I see, you brought a good point - we are not checking the name either currently, so I'm fine with not doing it now and creating a follow up JIRA for that.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 10:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 10:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > Thank you very much for putting this patch together Veena! Overall I like the approach and have only few questions/comments (mostly real nits):
> >
> > 1) I think that I broke the patch by committing postgresql integration tests:
> >
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[151,19] cannot find symbol
> > [ERROR] symbol : constructor MStringInput(java.lang.String,boolean,short)
> > [ERROR] location: class org.apache.sqoop.model.MStringInput
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[153,12] cannot find symbol
> >
> > 2) I'm slightly worries that we are not doing any defensive checking for the overrides field. We are keeping the "overrides" only as comma separated string and we are not verifying anywhere that it actually contains only valid values (e.g. other configs that do exists). The only place where we are sort of doing that is in the repository where we are actually translating the values to ids, but that seems quite late in the process. Do you think that we could add those checks somewhere sooner? Perhaps to the ConfigUtils class? (e.g. let's fail fast)
>
> Veena Basavaraj wrote:
> it is done when w register the configs/ inserting to the database, wont this cover all paths,?
The word defensive did not make sense to me and confused me, defensive mean we catch the issue and the current code does it, if it a matter of checking this in the config utils and not in repository code, i will move it there, not a big deal.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 2:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, line 136
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line136>
> >
> > I think that the id here is not adding much value, right? The primary key can be simply (PARENT_ID, CHILD_ID).
>
> Veena Basavaraj wrote:
> @gwem what do you think? it feels weird to m
from gwen: we have surrogate pks through the entire repository, afaik
can't see why this table will be different
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 2:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 2:25 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java, lines 125-139
> > <https://reviews.apache.org/r/30537/diff/5/?file=846636#file846636line125>
> >
> > It seems to me that we are storing the same information twice - we have the input names stored in one table and their corresponding ids in second table. I'm wondering if that is necessary?
>
> Veena Basavaraj wrote:
> nto sure i understand, we are storing relation here, so we can infer it
dropped the overrides field on SQ_INPUT
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
On Feb. 4, 2015, 2:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review71043
-----------------------------------------------------------
Thank you very much for putting this patch together Veena! Overall I like the approach and have only few questions/comments (mostly real nits):
1) I think that I broke the patch by committing postgresql integration tests:
[ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[151,19] cannot find symbol
[ERROR] symbol : constructor MStringInput(java.lang.String,boolean,short)
[ERROR] location: class org.apache.sqoop.model.MStringInput
[ERROR] /Users/jarcec/apache/sqoop2-vanila/repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java:[153,12] cannot find symbol
2) I'm slightly worries that we are not doing any defensive checking for the overrides field. We are keeping the "overrides" only as comma separated string and we are not verifying anywhere that it actually contains only valid values (e.g. other configs that do exists). The only place where we are sort of doing that is in the repository where we are actually translating the values to ids, but that seems quite late in the process. Do you think that we could add those checks somewhere sooner? Perhaps to the ConfigUtils class? (e.g. let's fail fast)
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java
<https://reviews.apache.org/r/30537/#comment116568>
Super nit: can we add comma at this line?
By doing this, we won't have to change this line next time we will be adding a new error code which makes use of "git blame" slightly easier.
common/src/main/java/org/apache/sqoop/model/Input.java
<https://reviews.apache.org/r/30537/#comment116569>
Nit: I know that we had discussion about making it array of objects and decided not to because it would be too complex, but what perhaps array of strings? Like:
String [] overrides() default {};
We have similar idiom with the validators (it's an array of something), so it seems a bit nicer. I don't feel super strongly about this one though, so if we feel that this is better, I'm fine.
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
<https://reviews.apache.org/r/30537/#comment116572>
I'm not immediately sure why we are removing this fragment?
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java
<https://reviews.apache.org/r/30537/#comment116586>
It seems to me that we are storing the same information twice - we have the input names stored in one table and their corresponding ids in second table. I'm wondering if that is necessary?
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java
<https://reviews.apache.org/r/30537/#comment116581>
Can we put somewhere (probably into ConfigUtils) verification code that will ensure that the string is less then the 32 characters? I'm afraid that connector developper will try to use more and "random" things will start happening.
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java
<https://reviews.apache.org/r/30537/#comment116584>
I think that the id here is not adding much value, right? The primary key can be simply (PARENT_ID, CHILD_ID).
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java
<https://reviews.apache.org/r/30537/#comment116575>
Nit: Trailing whitespace
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/30537/#comment116576>
Nit: It seems taht we are just removing the spaces which we seem to be using everywhere else in the project?
(applicable for entire file)
Jarcec
- Jarek Cecho
On Feb. 4, 2015, 10:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 10:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 2:02 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 08a3342
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 2b5a9b7
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 9:57 a.m., Gwen Shapira wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, lines 62-66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line62>
> >
> > I think this should be a List of Input and not a String with commas.
> > This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
>
> Veena Basavaraj wrote:
> it is just names of inputs at this point, we validate that the input names exist etc in the code.
>
> from String to List<MInput> ? and how is it expressed in the actual config class.
Would just be even easier if you can provide the sample code here.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
On Feb. 3, 2015, 2:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 2:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Gwen Shapira <gs...@cloudera.com>.
> On Feb. 4, 2015, 5:57 p.m., Gwen Shapira wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, lines 62-66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line62>
> >
> > I think this should be a List of Input and not a String with commas.
> > This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
>
> Veena Basavaraj wrote:
> it is just names of inputs at this point, we validate that the input names exist etc in the code.
>
> from String to List<MInput> ? and how is it expressed in the actual config class.
>
> Veena Basavaraj wrote:
> Would just be even easier if you can provide the sample code here.
>
> Gwen Shapira wrote:
> Yep, I saw that. So why keep it as string and then convert to List<MInput> later? Any reason not to start with the list?
> We are not limited to primitives here, for examples, we use a List of Validators, so I can't see why not List of Inputs...
following discussion with Veena:
the syntax for list of inputs is verbose, and we expect very short lists that will be converted to actual lists early on (and that only refers to inputs defined in the same Config class)
So, ok with leaving this as is.
- Gwen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
On Feb. 3, 2015, 10:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 10:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 9:57 a.m., Gwen Shapira wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, lines 62-66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line62>
> >
> > I think this should be a List of Input and not a String with commas.
> > This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
it is just names of inputs at this point, we validate that the input names exist etc in the code.
from String to List<MInput> ? and how is it expressed in the actual config class.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
On Feb. 3, 2015, 2:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 2:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Feb. 4, 2015, 9:57 a.m., Gwen Shapira wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, lines 62-66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line62>
> >
> > I think this should be a List of Input and not a String with commas.
> > This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
>
> Veena Basavaraj wrote:
> it is just names of inputs at this point, we validate that the input names exist etc in the code.
>
> from String to List<MInput> ? and how is it expressed in the actual config class.
>
> Veena Basavaraj wrote:
> Would just be even easier if you can provide the sample code here.
>
> Gwen Shapira wrote:
> Yep, I saw that. So why keep it as string and then convert to List<MInput> later? Any reason not to start with the list?
> We are not limited to primitives here, for examples, we use a List of Validators, so I can't see why not List of Inputs...
>
> Gwen Shapira wrote:
> following discussion with Veena:
> the syntax for list of inputs is verbose, and we expect very short lists that will be converted to actual lists early on (and that only refers to inputs defined in the same Config class)
>
> So, ok with leaving this as is.
As we discussed
1. compile time check would be nice, if we allowed dependency on inputs outside of the config class, we do not do that at this point
2. the syntax gets very verbose overrides = { @Input(public string last_value)}, we are duplicating all the aspects of the @Input including its attributes, that exists right there in that class. Validators on the other hand are external classes. so it does make sense to be more verbose
3. I would also see a value if we see this been used extensively, we can alsways deprecate the string and use List<MInput> in the signature ( we may use another name overridesList,
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
On Feb. 3, 2015, 2:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 2:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Gwen Shapira <gs...@cloudera.com>.
> On Feb. 4, 2015, 5:57 p.m., Gwen Shapira wrote:
> > common/src/main/java/org/apache/sqoop/model/Input.java, lines 62-66
> > <https://reviews.apache.org/r/30537/diff/5/?file=846604#file846604line62>
> >
> > I think this should be a List of Input and not a String with commas.
> > This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
>
> Veena Basavaraj wrote:
> it is just names of inputs at this point, we validate that the input names exist etc in the code.
>
> from String to List<MInput> ? and how is it expressed in the actual config class.
>
> Veena Basavaraj wrote:
> Would just be even easier if you can provide the sample code here.
Yep, I saw that. So why keep it as string and then convert to List<MInput> later? Any reason not to start with the list?
We are not limited to primitives here, for examples, we use a List of Validators, so I can't see why not List of Inputs...
- Gwen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
On Feb. 3, 2015, 10:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 10:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/#review70993
-----------------------------------------------------------
common/src/main/java/org/apache/sqoop/model/Input.java
<https://reviews.apache.org/r/30537/#comment116487>
I think this should be a List of Input and not a String with commas.
This will ensure that we depend on Inputs that actually exist and will be easier to use in the code (where we actually implement the overrides) later.
- Gwen Shapira
On Feb. 3, 2015, 10:01 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30537/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 10:01 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1804
> https://issues.apache.org/jira/browse/SQOOP-1804
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> derby updates
> for input attributes
> and storing input relations
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
> common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
> common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
> common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
> common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
> common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
> common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
> common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
> common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
> common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
> common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
> common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
> common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
> common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
> common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
> shell/src/main/resources/shell-resource.properties 2b5a9b7
>
> Diff: https://reviews.apache.org/r/30537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 2:01 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 952be3f
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4feaee6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 8626b31
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2f05fcb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java ad80797
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fa6710b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java ca387d8
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 2b5a9b7
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 1:02 p.m.)
Review request for Sqoop.
Changes
-------
+ few more tests
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java 7a7b28c
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1e13932
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 69c55df
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 6d35143
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 4a7afcf
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java d5cabd0
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 6a64fcc
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 11:23 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java 7a7b28c
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1e13932
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 69c55df
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 6d35143
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 4a7afcf
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java d5cabd0
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 6a64fcc
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 30537: SQOOP-1804:Repository Structure + API:
Storing/Retrieving the From/To config inputs ( editable/ overrides)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30537/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 11:22 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1804
https://issues.apache.org/jira/browse/SQOOP-1804
Repository: sqoop-sqoop2
Description
-------
see JIRA
derby updates
for input attributes
and storing input relations
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 5d261de
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 8b11ed5
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 279f3a6
common/src/main/java/org/apache/sqoop/model/Input.java b6305f2
common/src/main/java/org/apache/sqoop/model/InputEditable.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java c7fcf90
common/src/main/java/org/apache/sqoop/model/MConfig.java d128441
common/src/main/java/org/apache/sqoop/model/MEnumInput.java 74838fc
common/src/main/java/org/apache/sqoop/model/MInput.java d1c2ab6
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java de50cd4
common/src/main/java/org/apache/sqoop/model/MMapInput.java cf781b2
common/src/main/java/org/apache/sqoop/model/MStringInput.java 4854838
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java 7f0e2f1
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 10ac3cf
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 64ffdd1
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java c0644e7
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 57d2da2
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 908348d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 4f8261c
common/src/test/java/org/apache/sqoop/model/TestMConnector.java e1c02aa
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 39f09ce
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 69e511f
common/src/test/java/org/apache/sqoop/model/TestMJob.java 605f429
common/src/test/java/org/apache/sqoop/model/TestMLink.java e985c17
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java c9b786b
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f851cbd
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java a4faf95
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java f0bdda4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java 1b1fa7f
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java d4522ae
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java 7a7b28c
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1e13932
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 69c55df
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 4ab07b2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 6d35143
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java a551094
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 4a7afcf
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java d5cabd0
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java be8c23e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca24398
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java e12bf46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java fb07152
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java e240163
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java de40818
shell/src/main/resources/shell-resource.properties 6a64fcc
Diff: https://reviews.apache.org/r/30537/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj