[GitHub] [ignite-3] lowka commented on a diff in pull request #2616: IGNITE-20476: improve checking SQL exceptions in tests

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2616:
URL: https://github.com/apache/ignite-3/pull/2616#discussion_r1335849265


##########
modules/jdbc/src/integrationTest/java/org/apache/ignite/jdbc/ItJdbcComplexQuerySelfTest.java:
##########
@@ -209,21 +208,25 @@ public void testWrongArgumentType() throws Exception {
         }
 
         // Check non-indexed field.
-        assertThrows(SQLException.class, () -> {
-            try (ResultSet rs = stmt.executeQuery("select * from PUBLIC.Org where name = 2")) {
-                assertFalse(rs.next());
-            }
-        });
+        JdbcTestUtils.assertThrowsSqlException(

Review Comment:
   Maybe we can use `import static` instead of `JdbcTestUtils.assertThrowsSqlException`, because most of the code uses `import static JdbcTestUtils.assertThrowsSqlException`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org