You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2017/08/28 22:26:35 UTC
[Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
Dan Hecht has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7863
Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
......................................................................
IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
When given an invalid query id, most RPCs result with "Invalid query
id", but GetResultSetMetadata() response with "Unable to find session ID
for query handle". That's confusing; make it consistent with other
RPCs.
Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
---
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/hs2/test_hs2.py
4 files changed, 15 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7863/1
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7863
to look at the new patch set (#2).
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
When given an invalid query id, most RPCs result with "Invalid query
id", but GetResultSetMetadata() response with "Unable to find session ID
for query handle". That's confusing; make it consistent with other
RPCs.
Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
---
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/hs2/test_hs2.py
4 files changed, 14 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7863/2
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7863/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
> Nit: say what you did, not what was wrong.
Done
http://gerrit.cloudera.org:8080/#/c/7863/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:
PS1, Line 276: print get_result_set_metadata_resp.status.errorMessage
> I don't think this should be here, nor on line 265. It would get printed if
Done
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
Patch Set 2: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
When given an invalid query id, most RPCs result with "Invalid query
id", but GetResultSetMetadata() response with "Unable to find session ID
for query handle". That's confusing; make it consistent with other
RPCs.
Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Reviewed-on: http://gerrit.cloudera.org:8080/7863
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/hs2/test_hs2.py
4 files changed, 14 insertions(+), 31 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1162/
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7863/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
Nit: say what you did, not what was wrong.
http://gerrit.cloudera.org:8080/#/c/7863/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:
PS1, Line 276: print get_result_set_metadata_resp.status.errorMessage
I don't think this should be here, nor on line 265. It would get printed if the assert failed anyhow.
--
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes