You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org> on 2026/09/05 08:27:29 UTC

[PR] [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to … [flink]

Alwaysgaurav1 opened a new pull request, #29111:
URL: https://github.com/apache/flink/pull/29111

   ## What is the purpose of the change
   
   This pull request migrates legacy JUnit 4 and Hamcrest test assertions in `flink-statebackend-rocksdb` to JUnit 5 (Jupiter) and AssertJ in accordance with Apache Flink test standards.
   
   ## Brief change log
   
   - Migrated `RocksDBMemoryControllerUtilsTest` to JUnit 5 (`@TempDir`, `@BeforeAll`) and AssertJ assertions.
   - Migrated `RocksDBResourceContainerTest` to JUnit 5 and AssertJ assertions.
   - Migrated `RocksDBWriteBatchWrapperTest` to JUnit 5 and `assertThatThrownBy(...)` / AssertJ assertions.
   - Migrated `RocksDBNativeMetricOptionsTest` to JUnit 5 and AssertJ assertions.
   
   ## Verifying this change
   
   This change is a code refactoring of test suites without any changes to existing production runtime logic.
   
   - Run maven tests:
     `mvn test -pl flink-state-backends/flink-statebackend-rocksdb -am -Dfast -Dtest=RocksDBMemoryControllerUtilsTest,RocksDBResourceContainerTest,RocksDBWriteBatchWrapperTest,RocksDBNativeMetricOptionsTest -Dsurefire.failIfNoSpecifiedTests=false`
   - All 30 tests pass cleanly with 0 failures and 0 errors.
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to … [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #29111: [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to …
URL: https://github.com/apache/flink/pull/29111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to … [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #29111:
URL: https://github.com/apache/flink/pull/29111#issuecomment-6123340387

   This overlaps with #28943, which covers the whole module under FLINK-29775. Could you close this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to … [flink]

Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #29111:
URL: https://github.com/apache/flink/pull/29111#issuecomment-5550623326

   Hi @Alwaysgaurav1 
   Looks like a duplicate to https://github.com/apache/flink/pull/28943 and https://issues.apache.org/jira/browse/FLINK-29775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-XXXXX][state-backends] Migrate RocksDB state backend tests to … [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29111:
URL: https://github.com/apache/flink/pull/29111#issuecomment-5550656370

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9052e39ad9e01d216464d87870dded60a9832a2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d9052e39ad9e01d216464d87870dded60a9832a2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9052e39ad9e01d216464d87870dded60a9832a2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org