You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2015/06/15 17:37:20 UTC
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
GitHub user andreaturli opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/689
move all camp code to EntityManagementUtils
first baby-step to remove CAMP dependencies from `core`
@neykov, @ahgittin could you guys please have a look?
Next steps:
- extract a common interface called `SpecCreator` to replace the CAMP specific-calls inside `EntityManagementUtils`. This will use SPI to plug different implementation of the `SpecCreator`
- move `camp.brooklyn.api` to `/usage/camp`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/incubator-brooklyn feature/remove-camp-from-core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #689
----
commit 92bef8b3a21ac955d19293b013e80b254d9a0d91
Author: Andrea Turli <an...@gmail.com>
Date: 2015-06-15T15:32:37Z
move all camp code to EntityManagementUtils
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-124344999
@aledsage I think this PR needs to be closed as #760 supersedes it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-112128511
good points, @neykov I'll take care of those. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-113656792
@andreaturli does this replace PR #545? If so, should that be closed? Any comments there that are worth summarising here (rather than any viewer having to follow that link as well)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-112127060
The changes look straightforward. As the methods are static anyway, I'd scope them inside another class so it's clear the additions to `EntityManagementUtils` are strictly catalog related - but not important.
As a next step, before moving to extracting the interface, you should make sure that all calls to `PdpProcessor` and `AssemblyTemplateInstantiator` methods are moved to `EntityManagementUtils` (or similar).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-124338192
@andreaturli do you think this is ready to merge into master (which is now 0.8.0-SNAPSHOT) or is there anything you want to change before it's merged?
Also, does this replace #545, so should that be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-112487911
I'd say we leave this for after we cut the release (if it doesn't take too long), what do you think @andreaturli? It is still a work in progress?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by mikezaccardo <gi...@git.apache.org>.
Github user mikezaccardo commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-112483313
(LGTM)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: move all camp code to EntityManag...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/689#issuecomment-112517889
thanks @mikezaccardo and @neykov
I think it makes sense to post-pone this PR until we cut the release as it is still in-progress
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---