You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/22 11:46:31 UTC
[GitHub] [rocketmq] wangmingbo123 opened a new pull request #1739: fix error
wangmingbo123 opened a new pull request #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] lich0079 removed a comment on issue #1739: fix error
Posted by GitBox <gi...@apache.org>.
lich0079 removed a comment on issue #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739#issuecomment-581003531
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] wangmingbo123 commented on issue #1739: fix error
Posted by GitBox <gi...@apache.org>.
wangmingbo123 commented on issue #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739#issuecomment-586065350
is there anything wrong?
测试通过了，还有其他问题需要做的吗
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1739: fix error
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739#issuecomment-577151459
[](https://coveralls.io/builds/28256688)
Coverage increased (+0.004%) to 50.907% when pulling **eba5a3b6a708277bee770c23b73246d7d7a66ae6 on wangmingbo123:develop** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] vongosling closed pull request #1739: fix error
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] lich0079 commented on issue #1739: fix error
Posted by GitBox <gi...@apache.org>.
lich0079 commented on issue #1739: fix error
URL: https://github.com/apache/rocketmq/pull/1739#issuecomment-581003531
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services