You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/05/29 21:22:27 UTC
[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10533
Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters
......................................................................
IMPALA-7073: skip TestScannerReservation on non-miniclusters
The test is (sort of) tuned for miniclusters and is very targeted
to testing a specific code path, rather than general functional
correctness, so we don't really need coverage on all filesystems.
Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/10533/1
--
To view, visit http://gerrit.cloudera.org:8080/10533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Gerrit-Change-Number: 10533
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 )
Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2565/
--
To view, visit http://gerrit.cloudera.org:8080/10533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Gerrit-Change-Number: 10533
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 29 May 2018 21:31:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10533 )
Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters
......................................................................
IMPALA-7073: skip TestScannerReservation on non-miniclusters
The test is (sort of) tuned for miniclusters and is very targeted
to testing a specific code path, rather than general functional
correctness, so we don't really need coverage on all filesystems.
Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Reviewed-on: http://gerrit.cloudera.org:8080/10533
Reviewed-by: Thomas Marshall <th...@cmu.edu>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Thomas Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Gerrit-Change-Number: 10533
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 )
Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Gerrit-Change-Number: 10533
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 30 May 2018 00:38:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 )
Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7952f780cff80c08a6cbef898bf7b95c9bba5f6a
Gerrit-Change-Number: 10533
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 29 May 2018 21:29:41 +0000
Gerrit-HasComments: No