[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

[gvramana <gi...@git.apache.org>]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/189#discussion_r81474992
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -124,6 +124,7 @@ struct TableSchema{
     	1: required string table_id;  // ID used to
     	2: required list<ColumnSchema> table_columns; // Columns in the table
     	3: required SchemaEvolution schema_evolution; // History of schema evolution of this table
    +	4: optional i32 block_size
    --- End diff --
    
    @Zhangshunyu Actually need not change Schema for such extra properties which are being added. We can directly store TABLE_PROPERTIES as a string key value pairs in thrift. So that all such properties configuration parameters can be effectively handled without modifying thrift in future. @jackylk please comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---