[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #3061: Optimize memory：Support shrinking in ConcurrentLongLongPairHashMap

[GitBox <gi...@apache.org>]

hangc0276 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810427255



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##########
@@ -228,14 +305,27 @@ public void forEach(BiConsumerLongPair processor) {
         private volatile int capacity;
         private volatile int size;
         private int usedBuckets;
-        private int resizeThreshold;
-
-        Section(int capacity) {
+        private int resizeThresholdUp;
+        private int resizeThresholdBelow;
+        private final float mapFillFactor;
+        private final float mapIdleFactor;
+        private final float expandFactor;
+        private final float shrinkFactor;
+        private boolean autoShrink;

Review comment:
       set `autoShrink` to final?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org