You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/08/04 14:43:36 UTC

[GitHub] [cordova-plugin-file] grassick opened a new pull request, #534: (android) Fix issue #525

grassick opened a new pull request, #534:
URL: https://github.com/apache/cordova-plugin-file/pull/534

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   This solves issue https://github.com/apache/cordova-plugin-file/issues/525 which is a serious problem.
   
   Closes apache/cordova-plugin-file#525
   
   ### Description
   This implements the fix described in https://github.com/apache/cordova-plugin-file/issues/525#issue-1265882820
   
   
   
   ### Testing
   I tested locally, pushed to production. Approximately 1000 installs working with no issues.
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] erisu merged pull request #534: fix(android): FileError on a content resolveLocalFileSystemURL

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #534:
URL: https://github.com/apache/cordova-plugin-file/pull/534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] realtebo commented on pull request #534: (android) Fix issue #525

Posted by GitBox <gi...@apache.org>.
realtebo commented on PR #534:
URL: https://github.com/apache/cordova-plugin-file/pull/534#issuecomment-1367264229

   Please, fix this ASAP, because it's blocking some new projects


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] HarelM commented on pull request #534: (android) Fix issue #525

Posted by GitBox <gi...@apache.org>.
HarelM commented on PR #534:
URL: https://github.com/apache/cordova-plugin-file/pull/534#issuecomment-1245777140

   Is there any way for me to help push this forward?
   I haven't tested this with https, only with "default" capacitor configurations which is http and localhost.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] erisu commented on pull request #534: (android) Fix issue #525

Posted by GitBox <gi...@apache.org>.
erisu commented on PR #534:
URL: https://github.com/apache/cordova-plugin-file/pull/534#issuecomment-1209255810

   Was this tested against both use cases of using either http/https scheme and the file protocol?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org