You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/07/12 17:23:58 UTC

Review Request 60809: AMBARI-21455. Remove unnecessary services from BigInsights stack, fix rpm command in Remove IOP Select action

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60809/
-----------------------------------------------------------

Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-21455
    https://issues.apache.org/jira/browse/AMBARI-21455


Repository: ambari


Description
-------

Remove services that are not needed in BigInsights stack such as Titan and SYSTEMML, and all references to JNBG, R4ML.

Also, fix a bug when calling force_remove_packages.py in the "Remove IOP Select" action because the path to "rpm" should not be fully qualified.

```
ExecutionFailed: Execution of '/usr/bin/rpm -e --nodeps iop-select' returned 127. /var/lib/ambari-agent/ambari-sudo.sh: line 50: /usr/bin/rpm: No such file or directory
```


Diffs
-----

  ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 064b504 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/role_command_order.json dc4811b 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/stack_advisor.py 8883f57 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/role_command_order.json 5ee4b32 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/metainfo.xml b73e31e 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/__init__.py 5561e10 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/params.py dd7e46c 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/service_check.py c15b907 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/systemml_client.py 2d45b68 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-env.xml 4f80ea1 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-hbase-solr.xml dd45141 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-log4j.xml f61a479 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/kerberos.json ccabbf0 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/metainfo.xml 73f4635 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/files/titanSmoke.groovy 79438be 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/params.py 3cb7aef 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/service_check.py 3c011a1 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan.py fd94c82 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan_client.py d54ccee 


Diff: https://reviews.apache.org/r/60809/diff/1/


Testing
-------

Verified on local cluster.


Thanks,

Alejandro Fernandez


Re: Review Request 60809: AMBARI-21455. Remove unnecessary services from BigInsights stack

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60809/
-----------------------------------------------------------

(Updated July 12, 2017, 6:31 p.m.)


Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, and Sid Wagle.


Summary (updated)
-----------------

AMBARI-21455. Remove unnecessary services from BigInsights stack


Bugs: AMBARI-21455
    https://issues.apache.org/jira/browse/AMBARI-21455


Repository: ambari


Description (updated)
-------

Remove services that are not needed in BigInsights stack such as Titan and SYSTEMML, and all references to JNBG, R4ML.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/role_command_order.json dc4811b 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/stack_advisor.py 8883f57 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/role_command_order.json 5ee4b32 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/metainfo.xml b73e31e 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/__init__.py 5561e10 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/params.py dd7e46c 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/service_check.py c15b907 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/systemml_client.py 2d45b68 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-env.xml 4f80ea1 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-hbase-solr.xml dd45141 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-log4j.xml f61a479 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/kerberos.json ccabbf0 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/metainfo.xml 73f4635 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/files/titanSmoke.groovy 79438be 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/params.py 3cb7aef 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/service_check.py 3c011a1 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan.py fd94c82 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan_client.py d54ccee 


Diff: https://reviews.apache.org/r/60809/diff/2/

Changes: https://reviews.apache.org/r/60809/diff/1-2/


Testing
-------

Verified on local cluster.


Thanks,

Alejandro Fernandez


Re: Review Request 60809: AMBARI-21455. Remove unnecessary services from BigInsights stack, fix rpm command in Remove IOP Select action

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60809/#review180328
-----------------------------------------------------------


Ship it!





ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
Line 39 (original), 39 (patched)
<https://reviews.apache.org/r/60809/#comment255439>

    If you rebase, I think this was already committed.


- Jonathan Hurley


On July 12, 2017, 1:23 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60809/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 1:23 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21455
>     https://issues.apache.org/jira/browse/AMBARI-21455
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove services that are not needed in BigInsights stack such as Titan and SYSTEMML, and all references to JNBG, R4ML.
> 
> Also, fix a bug when calling force_remove_packages.py in the "Remove IOP Select" action because the path to "rpm" should not be fully qualified.
> 
> ```
> ExecutionFailed: Execution of '/usr/bin/rpm -e --nodeps iop-select' returned 127. /var/lib/ambari-agent/ambari-sudo.sh: line 50: /usr/bin/rpm: No such file or directory
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 064b504 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/role_command_order.json dc4811b 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/stack_advisor.py 8883f57 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/role_command_order.json 5ee4b32 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/metainfo.xml b73e31e 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/__init__.py 5561e10 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/params.py dd7e46c 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/service_check.py c15b907 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SYSTEMML/package/scripts/systemml_client.py 2d45b68 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-env.xml 4f80ea1 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-hbase-solr.xml dd45141 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/configuration/titan-log4j.xml f61a479 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/kerberos.json ccabbf0 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/metainfo.xml 73f4635 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/files/titanSmoke.groovy 79438be 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/params.py 3cb7aef 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/service_check.py 3c011a1 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan.py fd94c82 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/TITAN/package/scripts/titan_client.py d54ccee 
> 
> 
> Diff: https://reviews.apache.org/r/60809/diff/1/
> 
> 
> Testing
> -------
> 
> Verified on local cluster.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>