[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2850: Gradle build - some submodules are skipped

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #2850:
URL: https://github.com/apache/bookkeeper/pull/2850#discussion_r737184481



##########
File path: bin/common_gradle.sh
##########
@@ -245,7 +240,7 @@ set_module_classpath() {
     echo ${BK_CLASSPATH}
   else
     add_maven_deps_to_classpath ${MODULE_PATH} >&2
-    cat ${BK_HOME}/${MODULE_PATH}/build/classpath.txt

Review comment:
       I did the change because there were a sh test which check the cached_classpath.txt file.
   However I agree to duplicate sh tests in this case to facilitate maven removal, so I'm going to revert this change 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org